diff options
author | erikchen <erikchen@chromium.org> | 2015-09-22 11:47:00 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-09-22 18:49:04 +0000 |
commit | a8b611fd4d40c8be9d65a16853fcfb572e3302cd (patch) | |
tree | df229e74c3e9d46a22f6491f0ef133068551cca2 /ipc/ipc_channel_common.cc | |
parent | 94c1a3dd78fc09ef765a14a200f4347a43c2e32f (diff) | |
download | chromium_src-a8b611fd4d40c8be9d65a16853fcfb572e3302cd.zip chromium_src-a8b611fd4d40c8be9d65a16853fcfb572e3302cd.tar.gz chromium_src-a8b611fd4d40c8be9d65a16853fcfb572e3302cd.tar.bz2 |
Reland of land debugging for ipc related crash. (patchset #1 id:1 of https://codereview.chromium.org/1354863004/ )
Reason for revert:
Relanding this CL, as I don't think it will actually cause crashes.
https://code.google.com/p/chromium/issues/detail?id=524032#c27
Original issue's description:
> Revert of Reland debugging for ipc related crash. (patchset #1 id:1 of https://codereview.chromium.org/1354063002/ )
>
> Reason for revert:
> Supposedly, this CL only changes the signature of the crash, not the presence of the crash. There is some (but not totally clear) evidence that this CL is causing a crash itself.
>
> https://code.google.com/p/chromium/issues/detail?id=527588#c32
>
> Original issue's description:
> > Reland debugging for ipc related crash.
> >
> > This CL is almost identical to https://codereview.chromium.org/1350823002/. The
> > only difference is that the part of the CL that causes the crash has been
> > omitted.
> >
> > BUG=527588
> >
> > Committed: https://crrev.com/a7502c6dff276bce3c76d680c5d613cb6ece19be
> > Cr-Commit-Position: refs/heads/master@{#349828}
>
> TBR=avi@chromium.org,tsepez@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=527588
>
> Committed: https://crrev.com/dbc8c1869a4fd0493150c008106be720eba86205
> Cr-Commit-Position: refs/heads/master@{#350062}
TBR=avi@chromium.org,tsepez@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=527588
Review URL: https://codereview.chromium.org/1359933002
Cr-Commit-Position: refs/heads/master@{#350203}
Diffstat (limited to 'ipc/ipc_channel_common.cc')
-rw-r--r-- | ipc/ipc_channel_common.cc | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/ipc/ipc_channel_common.cc b/ipc/ipc_channel_common.cc index 5438c66..1a227ad 100644 --- a/ipc/ipc_channel_common.cc +++ b/ipc/ipc_channel_common.cc @@ -6,6 +6,8 @@ namespace IPC { +static Channel::MessageVerifier g_message_verifier = nullptr; + // static scoped_ptr<Channel> Channel::CreateClient( const IPC::ChannelHandle& channel_handle, @@ -56,6 +58,16 @@ scoped_ptr<Channel> Channel::CreateServer( Channel::~Channel() { } +// static +void Channel::SetMessageVerifier(MessageVerifier verifier) { + g_message_verifier = verifier; +} + +// static +Channel::MessageVerifier Channel::GetMessageVerifier() { + return g_message_verifier; +} + bool Channel::IsSendThreadSafe() const { return false; } |