diff options
| author | morrita@chromium.org <morrita@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-06 20:13:51 +0000 |
|---|---|---|
| committer | morrita@chromium.org <morrita@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-06 20:13:51 +0000 |
| commit | 2f60c9b74db6c61424a5a9c731acef26a9260c9c (patch) | |
| tree | ef3fb081703d0fb3f20f2d279f2d73310a14eac6 /ipc/ipc_channel_posix_unittest.cc | |
| parent | 42dbdaa6943939486e36e8ded5eb26f2419eeee3 (diff) | |
| download | chromium_src-2f60c9b74db6c61424a5a9c731acef26a9260c9c.zip chromium_src-2f60c9b74db6c61424a5a9c731acef26a9260c9c.tar.gz chromium_src-2f60c9b74db6c61424a5a9c731acef26a9260c9c.tar.bz2 | |
Make IPC::Channel polymorphic
This change makes each platform specific ChannelImpl into
a subclass of Channel: ChannelPosix, ChannelWin, ChannelNacl.
delegated functions are now virtual.
TEST=none
BUG=377980
R=darin@chromium.org, jam@chromium.org
Review URL: https://codereview.chromium.org/310293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275505 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc/ipc_channel_posix_unittest.cc')
| -rw-r--r-- | ipc/ipc_channel_posix_unittest.cc | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/ipc/ipc_channel_posix_unittest.cc b/ipc/ipc_channel_posix_unittest.cc index d001920..be43b2a 100644 --- a/ipc/ipc_channel_posix_unittest.cc +++ b/ipc/ipc_channel_posix_unittest.cc @@ -245,7 +245,8 @@ TEST_F(IPCChannelPosixTest, SendHangTest) { IPC::ChannelHandle in_handle("IN"); scoped_ptr<IPC::Channel> in_chan( IPC::Channel::CreateServer(in_handle, &in_listener)); - base::FileDescriptor out_fd(in_chan->TakeClientFileDescriptor(), false); + base::FileDescriptor out_fd( + in_chan->TakeClientFileDescriptor(), false); IPC::ChannelHandle out_handle("OUT", out_fd); scoped_ptr<IPC::Channel> out_chan( IPC::Channel::CreateClient(out_handle, &out_listener)); @@ -270,7 +271,8 @@ TEST_F(IPCChannelPosixTest, AcceptHangTest) { IPC::ChannelHandle in_handle("IN"); scoped_ptr<IPC::Channel> in_chan( IPC::Channel::CreateServer(in_handle, &in_listener)); - base::FileDescriptor out_fd(in_chan->TakeClientFileDescriptor(), false); + base::FileDescriptor out_fd( + in_chan->TakeClientFileDescriptor(), false); IPC::ChannelHandle out_handle("OUT", out_fd); scoped_ptr<IPC::Channel> out_chan( IPC::Channel::CreateClient(out_handle, &out_listener)); @@ -423,7 +425,7 @@ TEST_F(IPCChannelPosixTest, BadMode) { // Test setting up two servers with a bad mode. IPCChannelPosixTestListener listener(false); IPC::ChannelHandle chan_handle(GetConnectionSocketName()); - scoped_ptr<IPC::Channel> channel(IPC::Channel::CreateByModeForProxy( + scoped_ptr<IPC::Channel> channel(IPC::Channel::Create( chan_handle, IPC::Channel::MODE_NONE, &listener)); ASSERT_FALSE(channel->Connect()); } |