diff options
| author | bbudge@chromium.org <bbudge@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-28 15:30:04 +0000 |
|---|---|---|
| committer | bbudge@chromium.org <bbudge@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-28 15:30:04 +0000 |
| commit | 9ea0ecd0243f27205f9e6cf0ad2e554cc180e4cf (patch) | |
| tree | 37acb4b88e0631fd7c70f43675f72854f5429bfe /ipc/ipc_channel_posix_unittest.cc | |
| parent | 85372b02a7dfb87c35896c463296be5cdab305cb (diff) | |
| download | chromium_src-9ea0ecd0243f27205f9e6cf0ad2e554cc180e4cf.zip chromium_src-9ea0ecd0243f27205f9e6cf0ad2e554cc180e4cf.tar.gz chromium_src-9ea0ecd0243f27205f9e6cf0ad2e554cc180e4cf.tar.bz2 | |
Remove unused IPC::Message priority.
Removes the PriorityValue enum and field from IPC::Message. This doesn't
appear to be used anywhere.
Changes the data message ctor to take a size_t data_len parameter. This
works around an ambiguity problem with the main ctor, which has a similar
signature and would require lots of futzing with our test code to fix. To
make this work, the matching Pickle constructor is also changed to take a
size_t data_len parameter.
BUG=194304
Review URL: https://codereview.chromium.org/35643005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231330 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc/ipc_channel_posix_unittest.cc')
| -rw-r--r-- | ipc/ipc_channel_posix_unittest.cc | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/ipc/ipc_channel_posix_unittest.cc b/ipc/ipc_channel_posix_unittest.cc index 66ddeb2..3a00716 100644 --- a/ipc/ipc_channel_posix_unittest.cc +++ b/ipc/ipc_channel_posix_unittest.cc @@ -244,9 +244,8 @@ TEST_F(IPCChannelPosixTest, AdvancedConnected) { SpinRunLoop(TestTimeouts::action_max_timeout()); ASSERT_EQ(IPCChannelPosixTestListener::CONNECTED, listener.status()); ASSERT_TRUE(channel.HasAcceptedConnection()); - IPC::Message* message = new IPC::Message(0, // routing_id - kQuitMessage, // message type - IPC::Message::PRIORITY_NORMAL); + IPC::Message* message = new IPC::Message(0, /* routing_id */ + kQuitMessage /* message type */); channel.Send(message); SpinRunLoop(TestTimeouts::action_timeout()); int exit_code = 0; @@ -283,9 +282,8 @@ TEST_F(IPCChannelPosixTest, ResetState) { SpinRunLoop(TestTimeouts::action_max_timeout()); ASSERT_EQ(IPCChannelPosixTestListener::CONNECTED, listener.status()); ASSERT_TRUE(channel.HasAcceptedConnection()); - IPC::Message* message = new IPC::Message(0, // routing_id - kQuitMessage, // message type - IPC::Message::PRIORITY_NORMAL); + IPC::Message* message = new IPC::Message(0, /* routing_id */ + kQuitMessage /* message type */); channel.Send(message); SpinRunLoop(TestTimeouts::action_timeout()); EXPECT_TRUE(base::KillProcess(handle, 0, false)); @@ -342,9 +340,8 @@ TEST_F(IPCChannelPosixTest, MultiConnection) { EXPECT_EQ(exit_code, 0); ASSERT_EQ(IPCChannelPosixTestListener::DENIED, listener.status()); ASSERT_TRUE(channel.HasAcceptedConnection()); - IPC::Message* message = new IPC::Message(0, // routing_id - kQuitMessage, // message type - IPC::Message::PRIORITY_NORMAL); + IPC::Message* message = new IPC::Message(0, /* routing_id */ + kQuitMessage /* message type */); channel.Send(message); SpinRunLoop(TestTimeouts::action_timeout()); EXPECT_TRUE(base::WaitForExitCode(handle, &exit_code)); |