diff options
author | morrita@chromium.org <morrita@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-02 19:41:12 +0000 |
---|---|---|
committer | morrita@chromium.org <morrita@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-02 19:41:12 +0000 |
commit | cf178fb755d0fda06fd770c1a94eb8696063c001 (patch) | |
tree | 6e78f195f4731ec0231c538fc8377a3a41e8482b /ipc/ipc_channel_proxy.h | |
parent | 7d1c92a65a91100f4cae59626107b7b74aba536b (diff) | |
download | chromium_src-cf178fb755d0fda06fd770c1a94eb8696063c001.zip chromium_src-cf178fb755d0fda06fd770c1a94eb8696063c001.tar.gz chromium_src-cf178fb755d0fda06fd770c1a94eb8696063c001.tar.bz2 |
Introduce IPC::ChannelProxy::Create*() and IPC::SynChannel::Create*()
This change hides constructors of these classes so that we can turn
them polymorphic classes.
Note that having almost identical ChannelProxy::Init*() isn't great
and they will be replaced by a factory-like abstraction in coming
changes.
TEST=none
R=darin,cpu
BUG=377980
Review URL: https://codereview.chromium.org/301973003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274310 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc/ipc_channel_proxy.h')
-rw-r--r-- | ipc/ipc_channel_proxy.h | 46 |
1 files changed, 40 insertions, 6 deletions
diff --git a/ipc/ipc_channel_proxy.h b/ipc/ipc_channel_proxy.h index 0a3a5d2..d1f270d 100644 --- a/ipc/ipc_channel_proxy.h +++ b/ipc/ipc_channel_proxy.h @@ -64,10 +64,31 @@ class IPC_EXPORT ChannelProxy : public Sender, public base::NonThreadSafe { // on the background thread. Any message not handled by the filter will be // dispatched to the listener. The given task runner correspond to a thread // on which IPC::Channel is created and used (e.g. IO thread). - ChannelProxy(const IPC::ChannelHandle& channel_handle, - Channel::Mode mode, - Listener* listener, - base::SingleThreadTaskRunner* ipc_task_runner); + // The naming pattern follows IPC::Channel. The Create() does not create + // underlying channel and let Init*() do it. + static scoped_ptr<ChannelProxy> Create( + Listener* listener, + base::SingleThreadTaskRunner* ipc_task_runner); + + static scoped_ptr<ChannelProxy> CreateClient( + const IPC::ChannelHandle& channel_handle, + Listener* listener, + base::SingleThreadTaskRunner* ipc_task_runner); + + static scoped_ptr<ChannelProxy> CreateServer( + const IPC::ChannelHandle& channel_handle, + Listener* listener, + base::SingleThreadTaskRunner* ipc_task_runner); + + static scoped_ptr<ChannelProxy> CreateNamedClient( + const IPC::ChannelHandle& channel_handle, + Listener* listener, + base::SingleThreadTaskRunner* ipc_task_runner); + + static scoped_ptr<ChannelProxy> CreateNamedServer( + const IPC::ChannelHandle& channel_handle, + Listener* listener, + base::SingleThreadTaskRunner* ipc_task_runner); virtual ~ChannelProxy(); @@ -75,8 +96,17 @@ class IPC_EXPORT ChannelProxy : public Sender, public base::NonThreadSafe { // proxy that was not initialized in its constructor. If create_pipe_now is // true, the pipe is created synchronously. Otherwise it's created on the IO // thread. - void Init(const IPC::ChannelHandle& channel_handle, Channel::Mode mode, - bool create_pipe_now); + // The naming pattern follows IPC::Channel::Create*(). + void InitByMode(const IPC::ChannelHandle& channel_handle, Channel::Mode mode, + bool create_pipe_now); + void InitClient(const IPC::ChannelHandle& channel_handle, + bool create_pipe_now); + void InitServer(const IPC::ChannelHandle& channel_handle, + bool create_pipe_now); + void InitNamedClient(const IPC::ChannelHandle& channel_handle, + bool create_pipe_now); + void InitNamedServer(const IPC::ChannelHandle& channel_handle, + bool create_pipe_now); // Close the IPC::Channel. This operation completes asynchronously, once the // background thread processes the command to close the channel. It is ok to @@ -124,6 +154,10 @@ class IPC_EXPORT ChannelProxy : public Sender, public base::NonThreadSafe { // to the internal state. ChannelProxy(Context* context); + ChannelProxy(Listener* listener, + base::SingleThreadTaskRunner* ipc_task_runner); + + // Used internally to hold state that is referenced on the IPC thread. class Context : public base::RefCountedThreadSafe<Context>, public Listener { |