diff options
| author | erikchen <erikchen@chromium.org> | 2015-09-16 10:35:04 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-09-16 17:36:13 +0000 |
| commit | 1fa7dad91bc711eb1e481aa467a2f38c77cdae54 (patch) | |
| tree | 8a49f6ba7e937c8bb35b04c890ce0bf82aa42e56 /ipc/ipc_channel_reader.cc | |
| parent | 152f7f2870e2745de968e9dc21b1ee34099b967c (diff) | |
| download | chromium_src-1fa7dad91bc711eb1e481aa467a2f38c77cdae54.zip chromium_src-1fa7dad91bc711eb1e481aa467a2f38c77cdae54.tar.gz chromium_src-1fa7dad91bc711eb1e481aa467a2f38c77cdae54.tar.bz2 | |
Revert of Reland #2 "ipc: Add a new field num_brokered_attachments to the message header." (patchset #5 id:80001 of https://codereview.chromium.org/1334593002/ )
Reason for revert:
CL was only ever intended to be in 1 canary release.
Original issue's description:
> Reland #2 "ipc: Add a new field num_brokered_attachments to the message header."
>
> This original version of this CL is causing an unusual crash in Canary. This CL
> adds a message verifier to the ipc code so that it can dynamically verify the
> contents of this message that is being corrupted. This CL also verifies the
> message at several different points in the dispatch process. This will help
> narrow down the range of code that is corrupting the message.
>
> I expect this CL to cause ~100 crashes in the next Chrome Canary. I intend to
> revert this CL after a single Canary release.
>
> BUG=527588
>
> Committed: https://crrev.com/a2e71be46dc4bdcbb544db479680f65a390ae8f3
> Cr-Commit-Position: refs/heads/master@{#349056}
TBR=avi@chromium.org,tsepez@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=527588
Review URL: https://codereview.chromium.org/1350823002
Cr-Commit-Position: refs/heads/master@{#349152}
Diffstat (limited to 'ipc/ipc_channel_reader.cc')
| -rw-r--r-- | ipc/ipc_channel_reader.cc | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/ipc/ipc_channel_reader.cc b/ipc/ipc_channel_reader.cc index 8ec6694..031417b 100644 --- a/ipc/ipc_channel_reader.cc +++ b/ipc/ipc_channel_reader.cc @@ -11,7 +11,6 @@ #include "ipc/ipc_message.h" #include "ipc/ipc_message_attachment_set.h" #include "ipc/ipc_message_macros.h" -#include "ipc/ipc_message_start.h" namespace IPC { namespace internal { @@ -190,12 +189,6 @@ void ChannelReader::DispatchMessage(Message* m) { handled = GetAttachmentBroker()->OnMessageReceived(*m); } #endif // USE_ATTACHMENT_BROKER - - // TODO(erikchen): Temporary code to help track http://crbug.com/527588. - Channel::MessageVerifier verifier = Channel::GetMessageVerifier(); - if (verifier) - verifier(m); - if (!handled) listener_->OnMessageReceived(*m); if (m->dispatch_error()) |