diff options
| author | erikchen <erikchen@chromium.org> | 2015-09-23 11:23:53 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-09-23 18:26:01 +0000 |
| commit | fa2e4f2d931e0290ecab3df2e87b161795dfc7ac (patch) | |
| tree | b68e0f81bae90b2a3929ed99b904b7a3422a131f /ipc/ipc_channel_reader.cc | |
| parent | 482756beed446da615880a7f39ba43c3240011c3 (diff) | |
| download | chromium_src-fa2e4f2d931e0290ecab3df2e87b161795dfc7ac.zip chromium_src-fa2e4f2d931e0290ecab3df2e87b161795dfc7ac.tar.gz chromium_src-fa2e4f2d931e0290ecab3df2e87b161795dfc7ac.tar.bz2 | |
Revert of Reland debugging for ipc related crash.
Reason for revert:
Once again, seeing crashes.
https://crash.corp.google.com/browse?q=product.name%3D%27Chrome%27%20AND%20product.version%3D%2747.0.2517.0%27%20AND%20custom_data.ChromeCrashProto.ptype%3D%27renderer%27
Original issue's description:
> Reland of land debugging for ipc related crash. (patchset #1 id:1 of https://codereview.chromium.org/1354863004/ )
>
> Reason for revert:
> Relanding this CL, as I don't think it will actually cause crashes.
>
> https://code.google.com/p/chromium/issues/detail?id=524032#c27
>
> Original issue's description:
> > Revert of Reland debugging for ipc related crash. (patchset #1 id:1 of https://codereview.chromium.org/1354063002/ )
> >
> > Reason for revert:
> > Supposedly, this CL only changes the signature of the crash, not the presence of the crash. There is some (but not totally clear) evidence that this CL is causing a crash itself.
> >
> > https://code.google.com/p/chromium/issues/detail?id=527588#c32
> >
> > Original issue's description:
> > > Reland debugging for ipc related crash.
> > >
> > > This CL is almost identical to https://codereview.chromium.org/1350823002/. The
> > > only difference is that the part of the CL that causes the crash has been
> > > omitted.
> > >
> > > BUG=527588
> > >
> > > Committed: https://crrev.com/a7502c6dff276bce3c76d680c5d613cb6ece19be
> > > Cr-Commit-Position: refs/heads/master@{#349828}
> >
> > TBR=avi@chromium.org,tsepez@chromium.org
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=527588
> >
> > Committed: https://crrev.com/dbc8c1869a4fd0493150c008106be720eba86205
> > Cr-Commit-Position: refs/heads/master@{#350062}
>
> TBR=avi@chromium.org,tsepez@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=527588
>
> Committed: https://crrev.com/a8b611fd4d40c8be9d65a16853fcfb572e3302cd
> Cr-Commit-Position: refs/heads/master@{#350203}
TBR=avi@chromium.org,tsepez@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=527588
Review URL: https://codereview.chromium.org/1367543002
Cr-Commit-Position: refs/heads/master@{#350346}
Diffstat (limited to 'ipc/ipc_channel_reader.cc')
| -rw-r--r-- | ipc/ipc_channel_reader.cc | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/ipc/ipc_channel_reader.cc b/ipc/ipc_channel_reader.cc index 8ec6694..031417b 100644 --- a/ipc/ipc_channel_reader.cc +++ b/ipc/ipc_channel_reader.cc @@ -11,7 +11,6 @@ #include "ipc/ipc_message.h" #include "ipc/ipc_message_attachment_set.h" #include "ipc/ipc_message_macros.h" -#include "ipc/ipc_message_start.h" namespace IPC { namespace internal { @@ -190,12 +189,6 @@ void ChannelReader::DispatchMessage(Message* m) { handled = GetAttachmentBroker()->OnMessageReceived(*m); } #endif // USE_ATTACHMENT_BROKER - - // TODO(erikchen): Temporary code to help track http://crbug.com/527588. - Channel::MessageVerifier verifier = Channel::GetMessageVerifier(); - if (verifier) - verifier(m); - if (!handled) listener_->OnMessageReceived(*m); if (m->dispatch_error()) |