diff options
author | rvargas <rvargas@chromium.org> | 2014-09-15 19:44:15 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-09-16 02:45:38 +0000 |
commit | 431ce7382e8cae58d1dfbdde7c5c8bdc27daee2b (patch) | |
tree | e096b607391592158f26da9eb56d1f29db8e70ca /ipc/ipc_channel_win.h | |
parent | 6471a6bf42a061ebddf43665636e8f77c85c33b2 (diff) | |
download | chromium_src-431ce7382e8cae58d1dfbdde7c5c8bdc27daee2b.zip chromium_src-431ce7382e8cae58d1dfbdde7c5c8bdc27daee2b.tar.gz chromium_src-431ce7382e8cae58d1dfbdde7c5c8bdc27daee2b.tar.bz2 |
IPC: Add more debug info.
We're still seeing crashes that appear to come from multiple simultaneous
writes. Given that writing_ is false when we crash, but the operation
matches the current thread, file handle and IPC Channel, it could
be that for some reason a failed Write is still genarating a notification.
So this CL stores two error codes (one for the current operation and another
for a previous failure), and the write size.
BUG=387876
R=cpu@chromium.org
Review URL: https://codereview.chromium.org/564863003
Cr-Commit-Position: refs/heads/master@{#294993}
Diffstat (limited to 'ipc/ipc_channel_win.h')
-rw-r--r-- | ipc/ipc_channel_win.h | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/ipc/ipc_channel_win.h b/ipc/ipc_channel_win.h index e976aa3..dd341a7 100644 --- a/ipc/ipc_channel_win.h +++ b/ipc/ipc_channel_win.h @@ -98,7 +98,16 @@ class ChannelWin : public Channel, bool writing_; // Tracks the lifetime of this object, for debugging purposes. - int32 debug_flags_; + uint32 debug_flags_; + + // OS result for the current write. TODO(rvargas): remove this. + uint32 write_error_; + + // OS result for a previous failed write. TODO(rvargas): remove this. + uint32 last_write_error_; + + // Size of the current write. TODO(rvargas): remove this. + uint32 write_size_; // This is a unique per-channel value used to authenticate the client end of // a connection. If the value is non-zero, the client passes it in the hello |