diff options
author | bbudge@chromium.org <bbudge@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-28 15:30:04 +0000 |
---|---|---|
committer | bbudge@chromium.org <bbudge@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-28 15:30:04 +0000 |
commit | 9ea0ecd0243f27205f9e6cf0ad2e554cc180e4cf (patch) | |
tree | 37acb4b88e0631fd7c70f43675f72854f5429bfe /ipc/ipc_message.h | |
parent | 85372b02a7dfb87c35896c463296be5cdab305cb (diff) | |
download | chromium_src-9ea0ecd0243f27205f9e6cf0ad2e554cc180e4cf.zip chromium_src-9ea0ecd0243f27205f9e6cf0ad2e554cc180e4cf.tar.gz chromium_src-9ea0ecd0243f27205f9e6cf0ad2e554cc180e4cf.tar.bz2 |
Remove unused IPC::Message priority.
Removes the PriorityValue enum and field from IPC::Message. This doesn't
appear to be used anywhere.
Changes the data message ctor to take a size_t data_len parameter. This
works around an ambiguity problem with the main ctor, which has a similar
signature and would require lots of futzing with our test code to fix. To
make this work, the matching Pickle constructor is also changed to take a
size_t data_len parameter.
BUG=194304
Review URL: https://codereview.chromium.org/35643005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231330 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc/ipc_message.h')
-rw-r--r-- | ipc/ipc_message.h | 19 |
1 files changed, 4 insertions, 15 deletions
diff --git a/ipc/ipc_message.h b/ipc/ipc_message.h index 4209016..c071703 100644 --- a/ipc/ipc_message.h +++ b/ipc/ipc_message.h @@ -34,17 +34,11 @@ struct LogData; class IPC_EXPORT Message : public Pickle { public: - enum PriorityValue { - PRIORITY_LOW = 1, - PRIORITY_NORMAL, - PRIORITY_HIGH - }; - // Bit values used in the flags field. // Upper 24 bits of flags store a reference number, so this enum is limited to // 8 bits. enum { - PRIORITY_MASK = 0x03, // Low 2 bits of store the priority value. + UNUSED = 0x03, // Low 2 bits are not used. SYNC_BIT = 0x04, REPLY_BIT = 0x08, REPLY_ERROR_BIT = 0x10, @@ -57,22 +51,17 @@ class IPC_EXPORT Message : public Pickle { Message(); - // Initialize a message with a user-defined type, priority value, and - // destination WebView ID. - Message(int32 routing_id, uint32 type, PriorityValue priority); + // Initialize a message with routing ID and a user-defined type. + Message(int32 routing_id, uint32 type); // Initializes a message from a const block of data. The data is not copied; // instead the data is merely referenced by this message. Only const methods // should be used on the message when initialized this way. - Message(const char* data, int data_len); + Message(const char* data, size_t data_len); Message(const Message& other); Message& operator=(const Message& other); - PriorityValue priority() const { - return static_cast<PriorityValue>(header()->flags & PRIORITY_MASK); - } - // True if this is a synchronous message. void set_sync() { header()->flags |= SYNC_BIT; |