diff options
| author | bbudge@chromium.org <bbudge@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-28 15:30:04 +0000 |
|---|---|---|
| committer | bbudge@chromium.org <bbudge@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-28 15:30:04 +0000 |
| commit | 9ea0ecd0243f27205f9e6cf0ad2e554cc180e4cf (patch) | |
| tree | 37acb4b88e0631fd7c70f43675f72854f5429bfe /ipc/ipc_message_unittest.cc | |
| parent | 85372b02a7dfb87c35896c463296be5cdab305cb (diff) | |
| download | chromium_src-9ea0ecd0243f27205f9e6cf0ad2e554cc180e4cf.zip chromium_src-9ea0ecd0243f27205f9e6cf0ad2e554cc180e4cf.tar.gz chromium_src-9ea0ecd0243f27205f9e6cf0ad2e554cc180e4cf.tar.bz2 | |
Remove unused IPC::Message priority.
Removes the PriorityValue enum and field from IPC::Message. This doesn't
appear to be used anywhere.
Changes the data message ctor to take a size_t data_len parameter. This
works around an ambiguity problem with the main ctor, which has a similar
signature and would require lots of futzing with our test code to fix. To
make this work, the matching Pickle constructor is also changed to take a
size_t data_len parameter.
BUG=194304
Review URL: https://codereview.chromium.org/35643005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231330 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc/ipc_message_unittest.cc')
| -rw-r--r-- | ipc/ipc_message_unittest.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/ipc/ipc_message_unittest.cc b/ipc/ipc_message_unittest.cc index 971314a..e5215ce3 100644 --- a/ipc/ipc_message_unittest.cc +++ b/ipc/ipc_message_unittest.cc @@ -19,7 +19,7 @@ TEST(IPCMessageTest, ListValue) { input.Set(1, new base::StringValue("forty")); input.Set(2, base::Value::CreateNullValue()); - IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL); + IPC::Message msg(1, 2); IPC::WriteParam(&msg, input); base::ListValue output; @@ -29,7 +29,7 @@ TEST(IPCMessageTest, ListValue) { EXPECT_TRUE(input.Equals(&output)); // Also test the corrupt case. - IPC::Message bad_msg(1, 2, IPC::Message::PRIORITY_NORMAL); + IPC::Message bad_msg(1, 2); bad_msg.WriteInt(99); iter = PickleIterator(bad_msg); EXPECT_FALSE(IPC::ReadParam(&bad_msg, &iter, &output)); @@ -54,7 +54,7 @@ TEST(IPCMessageTest, DictionaryValue) { input.Set("dict", subdict.release()); - IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL); + IPC::Message msg(1, 2); IPC::WriteParam(&msg, input); base::DictionaryValue output; @@ -64,7 +64,7 @@ TEST(IPCMessageTest, DictionaryValue) { EXPECT_TRUE(input.Equals(&output)); // Also test the corrupt case. - IPC::Message bad_msg(1, 2, IPC::Message::PRIORITY_NORMAL); + IPC::Message bad_msg(1, 2); bad_msg.WriteInt(99); iter = PickleIterator(bad_msg); EXPECT_FALSE(IPC::ReadParam(&bad_msg, &iter, &output)); |