diff options
| author | piman@chromium.org <piman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-31 09:27:31 +0000 |
|---|---|---|
| committer | piman@chromium.org <piman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-31 09:27:31 +0000 |
| commit | 48328ffa464e69a526df2240320522e7272111ec (patch) | |
| tree | cd1e95bacdd9523376374d1740445a63c42757f7 /ipc/ipc_message_utils.h | |
| parent | 5eed857e813b68b4542419709f47205bcf275190 (diff) | |
| download | chromium_src-48328ffa464e69a526df2240320522e7272111ec.zip chromium_src-48328ffa464e69a526df2240320522e7272111ec.tar.gz chromium_src-48328ffa464e69a526df2240320522e7272111ec.tar.bz2 | |
Optimize ParamTraits<float> and ParamTraits<double>
These function become hot on some benchmarks. WriteData is inefficient because
it writes the length, even though it's known on the reader side (compile-time
constant).
For <float> we can simply use WriteFloat. For <double> we can use WriteBytes
instead of WriteData.
BUG=307480
Review URL: https://codereview.chromium.org/39363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232060 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc/ipc_message_utils.h')
| -rw-r--r-- | ipc/ipc_message_utils.h | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/ipc/ipc_message_utils.h b/ipc/ipc_message_utils.h index 7121c19..e9c0ba0b0 100644 --- a/ipc/ipc_message_utils.h +++ b/ipc/ipc_message_utils.h @@ -216,8 +216,12 @@ struct ParamTraits<unsigned long long> { template <> struct IPC_EXPORT ParamTraits<float> { typedef float param_type; - static void Write(Message* m, const param_type& p); - static bool Read(const Message* m, PickleIterator* iter, param_type* r); + static void Write(Message* m, const param_type& p) { + m->WriteFloat(p); + } + static bool Read(const Message* m, PickleIterator* iter, param_type* r) { + return m->ReadFloat(iter, r); + } static void Log(const param_type& p, std::string* l); }; |