diff options
| author | amistry <amistry@chromium.org> | 2015-09-02 11:04:22 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-09-02 18:05:40 +0000 |
| commit | 0b0e7480d9fd3816cbee891bf1618bc02b112cb4 (patch) | |
| tree | 340e6c6a5cfaeb0951737f49dbf035b3884c5044 /ipc/ipc_sender.h | |
| parent | 52c41cb25a551989d516abd79f0134d70a17b8d0 (diff) | |
| download | chromium_src-0b0e7480d9fd3816cbee891bf1618bc02b112cb4.zip chromium_src-0b0e7480d9fd3816cbee891bf1618bc02b112cb4.tar.gz chromium_src-0b0e7480d9fd3816cbee891bf1618bc02b112cb4.tar.bz2 | |
Fix races with MessagePipeReader due to the Mojo IPC channel being thread-safe.
This change does three things:
1. Checks the threading of MessagePipeReader using a ThreadChecker.
2. Eliminates races on |pending_send_error_| by using atomic ops.
3. Documents and removes checks which are no longer valid because Send()
can be called on a non-IO thread.
BUG=522888,492867
TESTED=Enabled Mojo IPC channel and ran StatsTableBrowserTest.StartWithStatTable
with tsan 100 times.
Before: IPC-related races and DCHECK failures
After: No IPC-related races and DCHECK failures.
Review URL: https://codereview.chromium.org/1318453002
Cr-Commit-Position: refs/heads/master@{#346967}
Diffstat (limited to 'ipc/ipc_sender.h')
0 files changed, 0 insertions, 0 deletions