diff options
| author | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-19 18:05:11 +0000 |
|---|---|---|
| committer | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-19 18:05:11 +0000 |
| commit | 29c5d23eeb86edb8a1ca8a97fb56b0a2e698b759 (patch) | |
| tree | bf9fe5f567e6fe59eeb8ee980b39dbb258e106ce /ipc/ipc_sync_channel.cc | |
| parent | 1c0e5732ac1faa5bf69dcd2cae5e91ac52b3fbf0 (diff) | |
| download | chromium_src-29c5d23eeb86edb8a1ca8a97fb56b0a2e698b759.zip chromium_src-29c5d23eeb86edb8a1ca8a97fb56b0a2e698b759.tar.gz chromium_src-29c5d23eeb86edb8a1ca8a97fb56b0a2e698b759.tar.bz2 | |
Fix IPC OnChannelConnected() to send correct PID on Linux/CrOS
Sandboxed renderers on Linux/CrOS are in a PID namespace, so they don't know
their own global PID. Thus the PID sent in the IPC channel Hello message
contains an unexpected value, which is used in the OnChannelConnected()
callback into chrome.
This causes problems like the Task Manager not showing any data for FPS,
JavaScript memory and image cache memory. The task manager is attempting to
use the PID/process handle from BrowserMessageFilter, which got it from
IPC::Channel::Listener::OnChannelConnected(), and it doesn't match the
global PID of each renderer.
BUG=70179
TEST=manual, open a few tabs, then open task manager, right-click to turn on JavaScript memory and image memory. Verify there are non-zero values for FPS, JavaScript memory, image cache memory
Review URL: http://codereview.chromium.org/7661004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97481 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc/ipc_sync_channel.cc')
| -rw-r--r-- | ipc/ipc_sync_channel.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/ipc/ipc_sync_channel.cc b/ipc/ipc_sync_channel.cc index c135ef3..9cb6454 100644 --- a/ipc/ipc_sync_channel.cc +++ b/ipc/ipc_sync_channel.cc @@ -377,6 +377,7 @@ SyncChannel::SyncChannel( WaitableEvent* shutdown_event) : ChannelProxy( channel_handle, mode, ipc_message_loop, + false /* needs_override_peer_pid */, new SyncContext(listener, ipc_message_loop, shutdown_event), create_pipe_now), sync_messages_with_no_timeout_allowed_(true) { |