diff options
| author | morrita <morrita@chromium.org> | 2014-09-23 14:16:00 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-09-23 21:16:28 +0000 |
| commit | 54f6f80c3623a6fb9d3049b6f5e0e23b1d76c34d (patch) | |
| tree | d5188994206cd43ae680f6e7325ec5c45075b9da /ipc/mojo/BUILD.gn | |
| parent | de9555146d87d2daf5e2e1da425d46b8efc06415 (diff) | |
| download | chromium_src-54f6f80c3623a6fb9d3049b6f5e0e23b1d76c34d.zip chromium_src-54f6f80c3623a6fb9d3049b6f5e0e23b1d76c34d.tar.gz chromium_src-54f6f80c3623a6fb9d3049b6f5e0e23b1d76c34d.tar.bz2 | |
IPC::ChannelMojo: Introduce IPC::MojoBootstrap for Windows
ChannelMojo doesn't work on Windows with existing implementaion
and this CL fixes it.
On Windows, ChannelHandle isn't immediately usable: The handle has
to be activated through ConnectNamedPipe() windows API, which is done in
its own Connect() handlshaking phase. ChannelMojo didn't Connect()
underlying channel and took the ChannelHandle over so the handle
wasn't activated.
Instead of hijacking underlying ChannelHandle, this CL actually Connect()s
underlying channel, creates a pipe on the server side, send one side of the
pipe to the client process, and use the pipe for the MessagePipe
initialization.
These initialization task is encapsulated behind new MojoBootstrap class.
ChannelMojo creates MojoBootstrap class to get the PlatformHandle which
is already activated and usable.
BUG=377980
TEST=ipc_mojo_bootstrap_unittest.cc, ipc_channel_mojo_unittest.cc
R=viettrungluu@chromium.org, darin@chromium.org, yzshen@chromium.org
Review URL: https://codereview.chromium.org/553283002
Cr-Commit-Position: refs/heads/master@{#296248}
Diffstat (limited to 'ipc/mojo/BUILD.gn')
| -rw-r--r-- | ipc/mojo/BUILD.gn | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/ipc/mojo/BUILD.gn b/ipc/mojo/BUILD.gn index 743a320..27c9cd9 100644 --- a/ipc/mojo/BUILD.gn +++ b/ipc/mojo/BUILD.gn @@ -6,8 +6,12 @@ component("mojo") { sources = [ "ipc_channel_mojo.cc", "ipc_channel_mojo.h", + "ipc_channel_mojo_host.cc", + "ipc_channel_mojo_host.h", "ipc_channel_mojo_readers.cc", "ipc_channel_mojo_readers.h", + "ipc_mojo_bootstrap.cc", + "ipc_mojo_bootstrap.h", "ipc_message_pipe_reader.cc", "ipc_message_pipe_reader.h", ] @@ -27,6 +31,7 @@ component("mojo") { test("ipc_mojo_unittests") { sources = [ "ipc_channel_mojo_unittest.cc", + "ipc_mojo_bootstrap_unittest.cc", "run_all_unittests.cc", ] |