diff options
author | morrita <morrita@chromium.org> | 2014-09-24 13:11:45 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-09-24 20:11:59 +0000 |
commit | 96693856edc35a538f6ea8f0bd6ab55c75e3e823 (patch) | |
tree | 33bf28816211d8c3a5039db1d2f3a1ac74adf59e /ipc/mojo/ipc_channel_mojo_unittest.cc | |
parent | 33169d9f2497a79fdde3ae51c5aa7266032526c7 (diff) | |
download | chromium_src-96693856edc35a538f6ea8f0bd6ab55c75e3e823.zip chromium_src-96693856edc35a538f6ea8f0bd6ab55c75e3e823.tar.gz chromium_src-96693856edc35a538f6ea8f0bd6ab55c75e3e823.tar.bz2 |
IPC: Get rid of FileDescriptor usage from FileDescriptorSet and Message
This is a step toward to killing FileDescriptor.
This change lets FiileDescriptorSet have both Files (for owning fds)
and PlatformFiles (for non-owning fds). Doing this, we no longer
need FileDescriptor which provides |auto_close| flag.
BUG=415294
TEST=ipc_tests, ipc_mojo_unittests
R=agl@chromium.org, jam@hcromium.org, viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/583473002
Cr-Commit-Position: refs/heads/master@{#296498}
Diffstat (limited to 'ipc/mojo/ipc_channel_mojo_unittest.cc')
-rw-r--r-- | ipc/mojo/ipc_channel_mojo_unittest.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/ipc/mojo/ipc_channel_mojo_unittest.cc b/ipc/mojo/ipc_channel_mojo_unittest.cc index 0763533..57a32a4 100644 --- a/ipc/mojo/ipc_channel_mojo_unittest.cc +++ b/ipc/mojo/ipc_channel_mojo_unittest.cc @@ -302,10 +302,11 @@ class ListenerThatExpectsFile : public IPC::Listener { virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE { PickleIterator iter(message); - base::FileDescriptor desc; - EXPECT_TRUE(message.ReadFileDescriptor(&iter, &desc)); + + base::ScopedFD fd; + EXPECT_TRUE(message.ReadFile(&iter, &fd)); + base::File file(fd.release()); std::string content(GetSendingFileContent().size(), ' '); - base::File file(desc.fd); file.Read(0, &content[0], content.size()); EXPECT_EQ(content, GetSendingFileContent()); base::MessageLoop::current()->Quit(); @@ -334,8 +335,7 @@ class ListenerThatExpectsFile : public IPC::Listener { file.Flush(); IPC::Message* message = new IPC::Message( 0, 2, IPC::Message::PRIORITY_NORMAL); - message->WriteFileDescriptor( - base::FileDescriptor(file.TakePlatformFile(), false)); + message->WriteFile(base::ScopedFD(file.TakePlatformFile())); ASSERT_TRUE(sender->Send(message)); } |