diff options
| author | rch <rch@chromium.org> | 2015-05-08 12:36:31 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-08 19:37:42 +0000 |
| commit | 1700960f576b111c00bd29fb72d27beddffecc7a (patch) | |
| tree | bcfdc0ef8c65167e31c170fef44ee478a761a0b2 /jingle/glue | |
| parent | 3b7c20e3097e55c99c943203a13fbae6cb05907e (diff) | |
| download | chromium_src-1700960f576b111c00bd29fb72d27beddffecc7a.zip chromium_src-1700960f576b111c00bd29fb72d27beddffecc7a.tar.gz chromium_src-1700960f576b111c00bd29fb72d27beddffecc7a.tar.bz2 | |
Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider (patchset #6 id:100001 of https://codereview.chromium.org/1114383003/)
Reason for revert:
Even adding methods which are not called breaks this bot. How in the hell is this possible?
http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26579
http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26579/steps/net_unittests%20%28iPhone%205%20iOS%208.1%29/logs/stdio
Original issue's description:
> Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider
> so that all provider subclasses can have their state verified.
>
> Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19
> Cr-Commit-Position: refs/heads/master@{#328154}
>
> Committed: https://crrev.com/269875cf0d23881a7ad119bae730ff54fdd4dd0b
> Cr-Commit-Position: refs/heads/master@{#328351}
>
> Committed: https://crrev.com/d833a674a5e4f3b4e47f229b3d5411a8d509c2c0
> Cr-Commit-Position: refs/heads/master@{#328909}
>
> Committed: https://crrev.com/1d6f67fe72b4a9ae94fcb0a6e051d803a180bde1
> Cr-Commit-Position: refs/heads/master@{#329003}
TBR=rtenneti@chromium.org,sergeyu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1126113003
Cr-Commit-Position: refs/heads/master@{#329015}
Diffstat (limited to 'jingle/glue')
| -rw-r--r-- | jingle/glue/chrome_async_socket_unittest.cc | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/jingle/glue/chrome_async_socket_unittest.cc b/jingle/glue/chrome_async_socket_unittest.cc index a785553..78b07a6 100644 --- a/jingle/glue/chrome_async_socket_unittest.cc +++ b/jingle/glue/chrome_async_socket_unittest.cc @@ -93,14 +93,6 @@ class AsyncSocketDataProvider : public net::SocketDataProvider { writes_.push_back(mock_write); } - bool AllReadDataConsumed() const override { - return reads_.empty(); - } - - bool AllWriteDataConsumed() const override { - return writes_.empty(); - } - private: std::deque<net::MockRead> reads_; bool has_pending_read_; |