diff options
| author | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-12 02:02:40 +0000 |
|---|---|---|
| committer | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-12 02:02:40 +0000 |
| commit | fe89ea7e351d304ca379125329018f5b96a2aded (patch) | |
| tree | f4a0a43fc9e626d3a8e015a363ebbab635154e4e /jingle/notifier/base | |
| parent | 1870d5cfa5ca359b44a32322c225cca1b2818e91 (diff) | |
| download | chromium_src-fe89ea7e351d304ca379125329018f5b96a2aded.zip chromium_src-fe89ea7e351d304ca379125329018f5b96a2aded.tar.gz chromium_src-fe89ea7e351d304ca379125329018f5b96a2aded.tar.bz2 | |
Miscelaneous cleanups to AddressList to make it harder to mis-use.
- Removed all destructive non-const member functions -- these were dangerous since if you called them without first making a copy of the AddressList, it could mutate earlier copies.
- Made AddressList::Data::head const, so new code added to AddressList cannot inadvertently introduce such dangerous mutations (won't compile).
- Moved the non-trivial constructors and assign methods into factory methods (for added readability)
- Removed the bool parameter from Copy (for added readability).
Review URL: http://codereview.chromium.org/6880302
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85090 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'jingle/notifier/base')
| -rw-r--r-- | jingle/notifier/base/chrome_async_socket_unittest.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/jingle/notifier/base/chrome_async_socket_unittest.cc b/jingle/notifier/base/chrome_async_socket_unittest.cc index f834d9d..53a2028 100644 --- a/jingle/notifier/base/chrome_async_socket_unittest.cc +++ b/jingle/notifier/base/chrome_async_socket_unittest.cc @@ -116,8 +116,8 @@ net::IPAddressNumber Uint32ToIPAddressNumber(uint32 ip) { net::AddressList SocketAddressToAddressList( const talk_base::SocketAddress& address) { DCHECK_NE(address.ip(), 0U); - return net::AddressList(Uint32ToIPAddressNumber(address.ip()), - address.port(), false); + return net::AddressList::CreateFromIPAddress( + Uint32ToIPAddressNumber(address.ip()), address.port()); } class MockXmppClientSocketFactory : public ResolvingClientSocketFactory { |