diff options
| author | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-11 22:27:54 +0000 |
|---|---|---|
| committer | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-11 22:27:54 +0000 |
| commit | 870bcb302d6597636fee73cd7bac110664b5a51d (patch) | |
| tree | ba441b6275c472d77b3b4e9f0d64d8a9ab2017a6 /jingle/notifier/communicator | |
| parent | 00cee28d45333558a3b7d842923d8e2eb07d7696 (diff) | |
| download | chromium_src-870bcb302d6597636fee73cd7bac110664b5a51d.zip chromium_src-870bcb302d6597636fee73cd7bac110664b5a51d.tar.gz chromium_src-870bcb302d6597636fee73cd7bac110664b5a51d.tar.bz2 | |
RefCounted types should not have public destructors - sync and jingle
In the process of ensuring no base classes for RefCounted classes have
public destructors, base::NonThreadSafe shows up frequently due to having
a public destructor.
Begin migrating all the code that has a base::NonThreadSafe member to
directly inheriting from base::NonThreadSafe, so that base::NonThreadSafe's
destructor can be made private.
BUG=123295
TEST=existing
Review URL: https://chromiumcodereview.appspot.com/10411046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141530 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'jingle/notifier/communicator')
| -rw-r--r-- | jingle/notifier/communicator/login.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/jingle/notifier/communicator/login.h b/jingle/notifier/communicator/login.h index d0667b1..d089cb6d6 100644 --- a/jingle/notifier/communicator/login.h +++ b/jingle/notifier/communicator/login.h @@ -45,11 +45,12 @@ class Login : public net::NetworkChangeNotifier::IPAddressObserver, public: class Delegate { public: - virtual ~Delegate() {} - virtual void OnConnect( base::WeakPtr<buzz::XmppTaskParentInterface> base_task) = 0; virtual void OnDisconnect() = 0; + + protected: + virtual ~Delegate() {} }; // Does not take ownership of |delegate|, which must not be NULL. |