jingle: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=zea@chromium.org, dcheng@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1729823003

Cr-Commit-Position: refs/heads/master@{#377992}

6 files changed, 9 insertions, 0 deletions

diff --git a/jingle/notifier/base/notifier_options.cc b/jingle/notifier/base/notifier_options.cc
index 3cf02ed..9a149a3 100644
--- a/jingle/notifier/base/notifier_options.cc
+++ b/jingle/notifier/base/notifier_options.cc
@@ -15,6 +15,8 @@ NotifierOptions::NotifierOptions()
       notification_method(kDefaultNotificationMethod),
       auth_mechanism(kDefaultGaiaAuthMechanism) {}
 
+NotifierOptions::NotifierOptions(const NotifierOptions& other) = default;
+
 NotifierOptions::~NotifierOptions() { }
 
 }  // namespace notifier
diff --git a/jingle/notifier/base/notifier_options.h b/jingle/notifier/base/notifier_options.h
index 0d7b471..08f03a8 100644
--- a/jingle/notifier/base/notifier_options.h
+++ b/jingle/notifier/base/notifier_options.h
@@ -16,6 +16,7 @@ namespace notifier {
 
 struct NotifierOptions {
   NotifierOptions();
+  NotifierOptions(const NotifierOptions& other);
   ~NotifierOptions();
 
   // Indicates that the SSLTCP port (443) is to be tried before the the XMPP
diff --git a/jingle/notifier/communicator/login_settings.cc b/jingle/notifier/communicator/login_settings.cc
index 3f1d3dd..0c665d1 100644
--- a/jingle/notifier/communicator/login_settings.cc
+++ b/jingle/notifier/communicator/login_settings.cc
@@ -28,6 +28,8 @@ LoginSettings::LoginSettings(const buzz::XmppClientSettings& user_settings,
   DCHECK_GT(default_servers_.size(), 0u);
 }
 
+LoginSettings::LoginSettings(const LoginSettings& other) = default;
+
 LoginSettings::~LoginSettings() {}
 
 void LoginSettings::set_user_settings(
diff --git a/jingle/notifier/communicator/login_settings.h b/jingle/notifier/communicator/login_settings.h
index 00a9589..c797bdd 100644
--- a/jingle/notifier/communicator/login_settings.h
+++ b/jingle/notifier/communicator/login_settings.h
@@ -23,6 +23,8 @@ class LoginSettings {
                 bool try_ssltcp_first,
                 const std::string& auth_mechanism);
 
+  LoginSettings(const LoginSettings& other);
+
   ~LoginSettings();
 
   // Copy constructor and assignment operator welcome.
diff --git a/jingle/notifier/listener/notification_defines.cc b/jingle/notifier/listener/notification_defines.cc
index f7c8f8f..8220f8d 100644
--- a/jingle/notifier/listener/notification_defines.cc
+++ b/jingle/notifier/listener/notification_defines.cc
@@ -55,6 +55,7 @@ bool RecipientListsEqual(const RecipientList& recipients1,
 }
 
 Notification::Notification() {}
+Notification::Notification(const Notification& other) = default;
 Notification::~Notification() {}
 
 bool Notification::Equals(const Notification& other) const {
diff --git a/jingle/notifier/listener/notification_defines.h b/jingle/notifier/listener/notification_defines.h
index 5d4a0c8..09d7e66 100644
--- a/jingle/notifier/listener/notification_defines.h
+++ b/jingle/notifier/listener/notification_defines.h
@@ -47,6 +47,7 @@ bool RecipientListsEqual(const RecipientList& recipients1,
 
 struct Notification {
   Notification();
+  Notification(const Notification& other);
   ~Notification();
 
   // The channel the notification is coming in on.