diff options
| author | nasko <nasko@chromium.org> | 2015-08-21 07:11:23 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-08-21 14:11:57 +0000 |
| commit | 5c19af794b141814a2a16c288a00ec1503e7142d (patch) | |
| tree | c32ea406ab4d673fb15078d5840454a587fc84cf /jingle | |
| parent | a85c20c17c0433419a0b777c68688712b2b2bde3 (diff) | |
| download | chromium_src-5c19af794b141814a2a16c288a00ec1503e7142d.zip chromium_src-5c19af794b141814a2a16c288a00ec1503e7142d.tar.gz chromium_src-5c19af794b141814a2a16c288a00ec1503e7142d.tar.bz2 | |
Revert of Sync more GN unit tests with GYP. (patchset #3 id:40001 of https://codereview.chromium.org/1301743003/ )
Reason for revert:
This has broken the GN builds. Windows is failing compilation and Mac is failing generate_build_files.
http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/15185/steps/generate_build_files/logs/stdio
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/5562/steps/compile/logs/stdio
Original issue's description:
> Sync more GN unit tests with GYP.
>
> This adds about 600 more tests.
>
> Tests added: invalidation, navigation interception, feedback, search, sync driver, enhanced bookmarks, search engines, sessions, data reduction proxy, favicon, constrained window, autofill, metrics, keyed service, bookmarks, suggestions, audio modem
>
> I renamed ui_zoom to "zoom" according to GN style. I tweaked some jingle public dependencies so the right include directories get forwarded along with the corresponding uses in the headers.
>
> BUG=
> R=dpranke@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/a7cde4bd39dc814952d885e54eee33ffdac1a881
TBR=dpranke@chromium.org,thestig@chromium.org,msramek@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1306153002
Cr-Commit-Position: refs/heads/master@{#344760}
Diffstat (limited to 'jingle')
| -rw-r--r-- | jingle/BUILD.gn | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/jingle/BUILD.gn b/jingle/BUILD.gn index 74030bc..3b6e0a2 100644 --- a/jingle/BUILD.gn +++ b/jingle/BUILD.gn @@ -103,11 +103,8 @@ if (enable_webrtc || !is_android) { "notifier/listener/fake_push_client_observer.cc", "notifier/listener/fake_push_client_observer.h", ] - public_deps = [ - ":jingle_glue", - ":notifier", - ] deps = [ + ":notifier", "//base", "//testing/gmock", ] |