diff options
| author | dbeam <dbeam@chromium.org> | 2015-05-04 20:56:16 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-05 03:56:44 +0000 |
| commit | 861e7ec31c1917c3c7447356be2a8a26cf8588b3 (patch) | |
| tree | d3ea6ac5f9dbe4d7c1ff23a8f50eef891db2f492 /jingle | |
| parent | 0d07f0a54926688f01a16c85734dbb28cf617f76 (diff) | |
| download | chromium_src-861e7ec31c1917c3c7447356be2a8a26cf8588b3.zip chromium_src-861e7ec31c1917c3c7447356be2a8a26cf8588b3.tar.gz chromium_src-861e7ec31c1917c3c7447356be2a8a26cf8588b3.tar.bz2 | |
Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider (patchset #3 id:40001 of https://codereview.chromium.org/1114383003/)
Reason for revert:
Final stop on the revert train!
net_unittests on iOS Simulator (dbg) (iPhone 5 ios 8.1) should be fixed after this?
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_(dbg)
Here's a log of the break:
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26378/steps/net_unittests%20%28iPhone%205%20iOS%208.1%29/logs/crash%20report%20%282015-05-04-164655%29
Original issue's description:
> Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider
> so that all provider subclasses can have their state verified.
>
> Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19
> Cr-Commit-Position: refs/heads/master@{#328154}
TBR=rtenneti@chromium.org,sergeyu@chromium.org,rch@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1119803006
Cr-Commit-Position: refs/heads/master@{#328271}
Diffstat (limited to 'jingle')
| -rw-r--r-- | jingle/glue/chrome_async_socket_unittest.cc | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/jingle/glue/chrome_async_socket_unittest.cc b/jingle/glue/chrome_async_socket_unittest.cc index a785553..78b07a6 100644 --- a/jingle/glue/chrome_async_socket_unittest.cc +++ b/jingle/glue/chrome_async_socket_unittest.cc @@ -93,14 +93,6 @@ class AsyncSocketDataProvider : public net::SocketDataProvider { writes_.push_back(mock_write); } - bool AllReadDataConsumed() const override { - return reads_.empty(); - } - - bool AllWriteDataConsumed() const override { - return writes_.empty(); - } - private: std::deque<net::MockRead> reads_; bool has_pending_read_; |