diff options
| author | piman <piman@chromium.org> | 2015-05-05 12:17:36 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-05 19:18:10 +0000 |
| commit | c9d7eff1fd9eefb46b27a3d6f4ecda16a9299122 (patch) | |
| tree | 43485291996c5919d82bd8b8bd90a94f9cd9d08e /jingle | |
| parent | 2833d58c524bbc1622015fd83f3a1a6f929ab288 (diff) | |
| download | chromium_src-c9d7eff1fd9eefb46b27a3d6f4ecda16a9299122.zip chromium_src-c9d7eff1fd9eefb46b27a3d6f4ecda16a9299122.tar.gz chromium_src-c9d7eff1fd9eefb46b27a3d6f4ecda16a9299122.tar.bz2 | |
Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider (patchset #4 id:60001 of https://codereview.chromium.org/1114383003/)
Reason for revert:
Suspected cause of IOS failure https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26420/steps/net_unittests%20%28iPhone%205%20iOS%208.1%29/logs/crash%20report%20%282015-05-05-113310%29
Original issue's description:
> Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider
> so that all provider subclasses can have their state verified.
>
> Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19
> Cr-Commit-Position: refs/heads/master@{#328154}
>
> Committed: https://crrev.com/269875cf0d23881a7ad119bae730ff54fdd4dd0b
> Cr-Commit-Position: refs/heads/master@{#328351}
TBR=rtenneti@chromium.org,sergeyu@chromium.org,rch@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1114353005
Cr-Commit-Position: refs/heads/master@{#328375}
Diffstat (limited to 'jingle')
| -rw-r--r-- | jingle/glue/chrome_async_socket_unittest.cc | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/jingle/glue/chrome_async_socket_unittest.cc b/jingle/glue/chrome_async_socket_unittest.cc index a785553..78b07a6 100644 --- a/jingle/glue/chrome_async_socket_unittest.cc +++ b/jingle/glue/chrome_async_socket_unittest.cc @@ -93,14 +93,6 @@ class AsyncSocketDataProvider : public net::SocketDataProvider { writes_.push_back(mock_write); } - bool AllReadDataConsumed() const override { - return reads_.empty(); - } - - bool AllWriteDataConsumed() const override { - return writes_.empty(); - } - private: std::deque<net::MockRead> reads_; bool has_pending_read_; |