diff options
| author | jam <jam@chromium.org> | 2015-11-06 09:16:29 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-11-06 17:18:01 +0000 |
| commit | 08c85fbce2720dfc1717c1f7d48aacad00c9c3c7 (patch) | |
| tree | 7ba30fb933ea629d5c4f47bc21847ecdaa268e63 /mandoline | |
| parent | 35b1c5a2321733b7b08e269d9eadcd3e67012aea (diff) | |
| download | chromium_src-08c85fbce2720dfc1717c1f7d48aacad00c9c3c7.zip chromium_src-08c85fbce2720dfc1717c1f7d48aacad00c9c3c7.tar.gz chromium_src-08c85fbce2720dfc1717c1f7d48aacad00c9c3c7.tar.bz2 | |
Get Mandoline working in component build.
Since state is now shared between apps and the shell, there could be bugs that don't exist in static builds. Running in multi-process (default for Mandoline now) makes this less of an issue, since no apps will share state. There's very little code that runs in the shell in a child process. --single-process works for now, but that could have more issues down the line. For now, this is really a developer productivity feature, just like component build in Chrome.
BUG=550498
Review URL: https://codereview.chromium.org/1410693004
Cr-Commit-Position: refs/heads/master@{#358343}
Diffstat (limited to 'mandoline')
| -rw-r--r-- | mandoline/BUILD.gn | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/mandoline/BUILD.gn b/mandoline/BUILD.gn index bc32cb0..e077bf0 100644 --- a/mandoline/BUILD.gn +++ b/mandoline/BUILD.gn @@ -12,15 +12,13 @@ group("all") { ":tests", ] - if (!is_component_build) { - if (is_android) { - deps += [ "//mandoline/app/android" ] - } else { - deps += [ - "//components/mus/example", - "//mandoline/app/desktop", - ] - } + if (is_android) { + deps += [ "//mandoline/app/android" ] + } else { + deps += [ + "//components/mus/example", + "//mandoline/app/desktop", + ] } } @@ -38,7 +36,7 @@ group("tests") { deps += [ "//tools/xdisplaycheck" ] } - if (!is_component_build && !is_mac) { + if (!is_mac) { deps += [ "//components/clipboard:apptests", "//components/filesystem:apptests", |