diff options
author | gab <gab@chromium.org> | 2015-11-11 15:37:19 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-11-11 23:38:14 +0000 |
commit | 4768aeea7babd463eae04fc7a51f318bad812885 (patch) | |
tree | 0a6201ff82c58af9b65df693d5ec133898474a66 /mandoline | |
parent | 76138f1c3dd4f74cae5b5f681cff1c3e68d5ef3d (diff) | |
download | chromium_src-4768aeea7babd463eae04fc7a51f318bad812885.zip chromium_src-4768aeea7babd463eae04fc7a51f318bad812885.tar.gz chromium_src-4768aeea7babd463eae04fc7a51f318bad812885.tar.bz2 |
Use TimeTicks as much as possible in startup_metric_utils.
BUG=544131, 521164
Review URL: https://codereview.chromium.org/1425263003
Cr-Commit-Position: refs/heads/master@{#359183}
Diffstat (limited to 'mandoline')
-rw-r--r-- | mandoline/ui/desktop_ui/browser_manager.cc | 2 | ||||
-rw-r--r-- | mandoline/ui/desktop_ui/browser_manager.h | 4 | ||||
-rw-r--r-- | mandoline/ui/desktop_ui/browser_window.cc | 11 |
3 files changed, 9 insertions, 8 deletions
diff --git a/mandoline/ui/desktop_ui/browser_manager.cc b/mandoline/ui/desktop_ui/browser_manager.cc index bef4dd5..3cb2b69 100644 --- a/mandoline/ui/desktop_ui/browser_manager.cc +++ b/mandoline/ui/desktop_ui/browser_manager.cc @@ -18,7 +18,7 @@ const char kGoogleURL[] = "http://www.google.com"; } // namespace BrowserManager::BrowserManager() - : app_(nullptr), startup_time_(base::Time::Now()) {} + : app_(nullptr), startup_ticks_(base::TimeTicks::Now()) {} BrowserManager::~BrowserManager() { while (!browsers_.empty()) diff --git a/mandoline/ui/desktop_ui/browser_manager.h b/mandoline/ui/desktop_ui/browser_manager.h index 88ed3fa..6eee78f 100644 --- a/mandoline/ui/desktop_ui/browser_manager.h +++ b/mandoline/ui/desktop_ui/browser_manager.h @@ -37,7 +37,7 @@ class BrowserManager : public mojo::ApplicationDelegate, void BrowserWindowClosed(BrowserWindow* browser); // Get the time recorded just before the application message loop was started. - const base::Time& startup_time() const { return startup_time_; } + const base::TimeTicks& startup_ticks() const { return startup_ticks_; } private: // Overridden from LaunchHandler: @@ -56,7 +56,7 @@ class BrowserManager : public mojo::ApplicationDelegate, mus::mojom::WindowTreeHostFactoryPtr host_factory_; mojo::WeakBindingSet<LaunchHandler> launch_handler_bindings_; std::set<BrowserWindow*> browsers_; - base::Time startup_time_; + const base::TimeTicks startup_ticks_; DISALLOW_COPY_AND_ASSIGN(BrowserManager); }; diff --git a/mandoline/ui/desktop_ui/browser_window.cc b/mandoline/ui/desktop_ui/browser_window.cc index 2b4ad48..a78e60e 100644 --- a/mandoline/ui/desktop_ui/browser_window.cc +++ b/mandoline/ui/desktop_ui/browser_window.cc @@ -170,7 +170,7 @@ void BrowserWindow::OnEmbed(mus::Window* root) { CHECK(!root_); // Record when the browser window was displayed, used for performance testing. - const base::Time display_time = base::Time::Now(); + const base::TimeTicks display_ticks = base::TimeTicks::Now(); root_ = root; @@ -214,7 +214,8 @@ void BrowserWindow::OnEmbed(mus::Window* root) { LoadURL(default_url_); // Record the time spent opening initial tabs, used for performance testing. - const base::TimeDelta open_tabs_delta = base::Time::Now() - display_time; + const base::TimeDelta open_tabs_delta = + base::TimeTicks::Now() - display_ticks; // Record the browser startup time metrics, used for performance testing. static bool recorded_browser_startup_metrics = false; @@ -225,10 +226,10 @@ void BrowserWindow::OnEmbed(mus::Window* root) { request->url = mojo::String::From("mojo:tracing"); tracing::StartupPerformanceDataCollectorPtr collector; app_->ConnectToService(request.Pass(), &collector); - collector->SetBrowserWindowDisplayTime(display_time.ToInternalValue()); + collector->SetBrowserWindowDisplayTicks(display_ticks.ToInternalValue()); collector->SetBrowserOpenTabsTimeDelta(open_tabs_delta.ToInternalValue()); - collector->SetBrowserMessageLoopStartTime( - manager_->startup_time().ToInternalValue()); + collector->SetBrowserMessageLoopStartTicks( + manager_->startup_ticks().ToInternalValue()); recorded_browser_startup_metrics = true; } } |