diff options
author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-08 21:43:30 +0000 |
---|---|---|
committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-08 21:43:30 +0000 |
commit | 7600d0b2d5e37b211280d5109a6b726644d6be76 (patch) | |
tree | 4ba2cb5383bb9ef5f610aeffe5d4455149da683b /media/audio | |
parent | a4f7378f973b38400f133958842eb36db0b61dcb (diff) | |
download | chromium_src-7600d0b2d5e37b211280d5109a6b726644d6be76.zip chromium_src-7600d0b2d5e37b211280d5109a6b726644d6be76.tar.gz chromium_src-7600d0b2d5e37b211280d5109a6b726644d6be76.tar.bz2 |
Revert 239400 "Revert 239280 "Move more file_util functions to b..."
Broke all bots 9_9
> Revert 239280 "Move more file_util functions to base namespace."
>
> dbus_unittests started fialing on Linux Tests (dbg)(2) and Linux Tests (dbg)(2)(32).
> This CL is the only in the intersection of CLs in the first failing build on
> the two builders, so giving a speculative revert a try (rlarocque already
> tried a clobber, it didn't help).
>
> http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/41806
> http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/builds/8544
>
>
> > Move more file_util functions to base namespace.
> >
> > TBR=sky
> >
> > Review URL: https://codereview.chromium.org/109043002
>
> TBR=brettw@chromium.org
>
> Review URL: https://codereview.chromium.org/105823009
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/100923007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239401 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/audio')
6 files changed, 14 insertions, 14 deletions
diff --git a/media/audio/android/audio_android_unittest.cc b/media/audio/android/audio_android_unittest.cc index 00d1f90..300e154 100644 --- a/media/audio/android/audio_android_unittest.cc +++ b/media/audio/android/audio_android_unittest.cc @@ -218,7 +218,7 @@ class FileAudioSink : public AudioInputStream::AudioInputCallback { base::FilePath file_path; EXPECT_TRUE(PathService::Get(base::DIR_SOURCE_ROOT, &file_path)); file_path = file_path.AppendASCII(file_name.c_str()); - binary_file_ = file_util::OpenFile(file_path, "wb"); + binary_file_ = base::OpenFile(file_path, "wb"); DLOG_IF(ERROR, !binary_file_) << "Failed to open binary PCM data file."; VLOG(0) << "Writing to file: " << file_path.value().c_str(); } @@ -239,7 +239,7 @@ class FileAudioSink : public AudioInputStream::AudioInputCallback { buffer_->Seek(chunk_size); bytes_written += chunk_size; } - file_util::CloseFile(binary_file_); + base::CloseFile(binary_file_); } // AudioInputStream::AudioInputCallback implementation. diff --git a/media/audio/audio_low_latency_input_output_unittest.cc b/media/audio/audio_low_latency_input_output_unittest.cc index 55ff1ed..c0cfa69 100644 --- a/media/audio/audio_low_latency_input_output_unittest.cc +++ b/media/audio/audio_low_latency_input_output_unittest.cc @@ -162,7 +162,7 @@ class FullDuplexAudioSinkSource EXPECT_TRUE(PathService::Get(base::DIR_EXE, &file_name)); file_name = file_name.AppendASCII(kDelayValuesFileName); - FILE* text_file = file_util::OpenFile(file_name, "wt"); + FILE* text_file = base::OpenFile(file_name, "wt"); DLOG_IF(ERROR, !text_file) << "Failed to open log file."; VLOG(0) << ">> Output file " << file_name.value() << " has been created."; @@ -180,7 +180,7 @@ class FullDuplexAudioSinkSource ++elements_written; } - file_util::CloseFile(text_file); + base::CloseFile(text_file); } // AudioInputStream::AudioInputCallback. diff --git a/media/audio/win/audio_low_latency_input_win_unittest.cc b/media/audio/win/audio_low_latency_input_win_unittest.cc index b34c237..54bd3f7 100644 --- a/media/audio/win/audio_low_latency_input_win_unittest.cc +++ b/media/audio/win/audio_low_latency_input_win_unittest.cc @@ -100,7 +100,7 @@ class WriteToFileAudioSink : public AudioInputStream::AudioInputCallback { base::FilePath file_path; EXPECT_TRUE(PathService::Get(base::DIR_EXE, &file_path)); file_path = file_path.AppendASCII(file_name); - binary_file_ = file_util::OpenFile(file_path, "wb"); + binary_file_ = base::OpenFile(file_path, "wb"); DLOG_IF(ERROR, !binary_file_) << "Failed to open binary PCM data file."; VLOG(0) << ">> Output file: " << file_path.value() << " has been created."; } @@ -120,7 +120,7 @@ class WriteToFileAudioSink : public AudioInputStream::AudioInputCallback { buffer_.Seek(chunk_size); bytes_written += chunk_size; } - file_util::CloseFile(binary_file_); + base::CloseFile(binary_file_); } // AudioInputStream::AudioInputCallback implementation. diff --git a/media/audio/win/audio_low_latency_output_win_unittest.cc b/media/audio/win/audio_low_latency_output_win_unittest.cc index 26d71f2..5fda4b1 100644 --- a/media/audio/win/audio_low_latency_output_win_unittest.cc +++ b/media/audio/win/audio_low_latency_output_win_unittest.cc @@ -97,7 +97,7 @@ class ReadFromFileAudioSource : public AudioOutputStream::AudioSourceCallback { file_name = file_name.AppendASCII(kDeltaTimeMsFileName); EXPECT_TRUE(!text_file_); - text_file_ = file_util::OpenFile(file_name, "wt"); + text_file_ = base::OpenFile(file_name, "wt"); DLOG_IF(ERROR, !text_file_) << "Failed to open log file."; // Write the array which contains delta times to a text file. @@ -107,7 +107,7 @@ class ReadFromFileAudioSource : public AudioOutputStream::AudioSourceCallback { ++elements_written; } - file_util::CloseFile(text_file_); + base::CloseFile(text_file_); } // AudioOutputStream::AudioSourceCallback implementation. diff --git a/media/audio/win/audio_unified_win.cc b/media/audio/win/audio_unified_win.cc index 848678d..901c8b8 100644 --- a/media/audio/win/audio_unified_win.cc +++ b/media/audio/win/audio_unified_win.cc @@ -161,7 +161,7 @@ WASAPIUnifiedStream::~WASAPIUnifiedStream() { base::FilePath data_file_name; PathService::Get(base::DIR_EXE, &data_file_name); data_file_name = data_file_name.AppendASCII(kUnifiedAudioDebugFileName); - data_file_ = file_util::OpenFile(data_file_name, "wt"); + data_file_ = base::OpenFile(data_file_name, "wt"); DVLOG(1) << ">> Output file " << data_file_name.value() << " is created."; size_t n = 0; @@ -175,16 +175,16 @@ WASAPIUnifiedStream::~WASAPIUnifiedStream() { fifo_rate_comps_[n]); ++n; } - file_util::CloseFile(data_file_); + base::CloseFile(data_file_); base::FilePath param_file_name; PathService::Get(base::DIR_EXE, ¶m_file_name); param_file_name = param_file_name.AppendASCII(kUnifiedAudioParamsFileName); - param_file_ = file_util::OpenFile(param_file_name, "wt"); + param_file_ = base::OpenFile(param_file_name, "wt"); DVLOG(1) << ">> Output file " << param_file_name.value() << " is created."; fprintf(param_file_, "%d %d\n", input_params_[0], input_params_[1]); fprintf(param_file_, "%d %d\n", output_params_[0], output_params_[1]); - file_util::CloseFile(param_file_); + base::CloseFile(param_file_); #endif } diff --git a/media/audio/win/audio_unified_win_unittest.cc b/media/audio/win/audio_unified_win_unittest.cc index 6c36665..15573ae 100644 --- a/media/audio/win/audio_unified_win_unittest.cc +++ b/media/audio/win/audio_unified_win_unittest.cc @@ -74,7 +74,7 @@ class UnifiedSourceCallback : public AudioOutputStream::AudioSourceCallback { file_name = file_name.AppendASCII(kDeltaTimeMsFileName); EXPECT_TRUE(!text_file_); - text_file_ = file_util::OpenFile(file_name, "wt"); + text_file_ = base::OpenFile(file_name, "wt"); DLOG_IF(ERROR, !text_file_) << "Failed to open log file."; VLOG(0) << ">> Output file " << file_name.value() << " has been created."; @@ -84,7 +84,7 @@ class UnifiedSourceCallback : public AudioOutputStream::AudioSourceCallback { fprintf(text_file_, "%d\n", delta_times_[elements_written]); ++elements_written; } - file_util::CloseFile(text_file_); + base::CloseFile(text_file_); } virtual int OnMoreData(AudioBus* dest, |