diff options
| author | dalecurtis@chromium.org <dalecurtis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-02 17:32:57 +0000 |
|---|---|---|
| committer | dalecurtis@chromium.org <dalecurtis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-02 17:32:57 +0000 |
| commit | 192c01ba51c7ca90c832f7002600542c7420cd6e (patch) | |
| tree | b61a511800924b41ccacfe9d01857da0a788ea10 /media/base/audio_buffer_converter.cc | |
| parent | 4f105be0a84999ff0b6fa3896a735459145eb8ad (diff) | |
| download | chromium_src-192c01ba51c7ca90c832f7002600542c7420cd6e.zip chromium_src-192c01ba51c7ca90c832f7002600542c7420cd6e.tar.gz chromium_src-192c01ba51c7ca90c832f7002600542c7420cd6e.tar.bz2 | |
Remove AudioBuffer::set_duration(), instead base on frames.
wolenetz@ asked on https://codereview.chromium.org/251893002/ why
we allow set_duration() to be called. It used to be required since
AudioBuffers had no concept of sample rate. However, we now attach
a sample rate to every AudioBuffer which allows us to enforce a
valid duration for every buffer.
This CL also aligns MakeAudioBuffer() to do the same thing with
planar and interleaved data for the sake of easier testing.
BUG=none
TEST=media_unittests
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267779
Review URL: https://codereview.chromium.org/261533002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267842 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/base/audio_buffer_converter.cc')
| -rw-r--r-- | media/base/audio_buffer_converter.cc | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/media/base/audio_buffer_converter.cc b/media/base/audio_buffer_converter.cc index 74e570d..59c6681 100644 --- a/media/base/audio_buffer_converter.cc +++ b/media/base/audio_buffer_converter.cc @@ -227,8 +227,6 @@ void AudioBufferConverter::ConvertIfPossible() { // Compute the timestamp. output_buffer->set_timestamp(timestamp_helper_.GetTimestamp()); - output_buffer->set_duration( - timestamp_helper_.GetFrameDuration(request_frames)); timestamp_helper_.AddFrames(request_frames); queued_outputs_.push_back(output_buffer); |