diff options
author | grunell <grunell@chromium.org> | 2015-08-21 12:37:26 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-08-21 19:38:11 +0000 |
commit | f5157bcf31af480a5462729a117fb2742a3d1224 (patch) | |
tree | 5024ad62f86cb26cc1b8d1d8bec8a0192a3c4ce4 /media/base/audio_capturer_source.h | |
parent | 12033f1290753504a3c324293689313b890e4ef2 (diff) | |
download | chromium_src-f5157bcf31af480a5462729a117fb2742a3d1224.zip chromium_src-f5157bcf31af480a5462729a117fb2742a3d1224.tar.gz chromium_src-f5157bcf31af480a5462729a117fb2742a3d1224.tar.bz2 |
Log error instead of CHECKing input audio sequence.
The check was landed yesterday (https://codereview.chromium.org/1293503002/) and we hit it on bots already, which gives good information to investigate. We need to keep the bots green, so changing it to log error instead.
Implementation details:
AudioCapturerSource::CaptureCallback::OnCaptureError now takes a message string. The webrtc capturer implementation of that function the logs message to the WebRTC log. If the sequence is incorrect in AudioInputDevice::AudioThreadCallback::Process we call OnCaptureError and also log to the Chrome log.
TBR'ing Dale for media/base/audio_capturer_source.h - this CL fixes ~50 % fail on Linux tsan bot so I' want to land it asap.
TBR=dalecurtis@chromium.org
BUG=523224
Review URL: https://codereview.chromium.org/1304173002
Cr-Commit-Position: refs/heads/master@{#344835}
Diffstat (limited to 'media/base/audio_capturer_source.h')
-rw-r--r-- | media/base/audio_capturer_source.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/media/base/audio_capturer_source.h b/media/base/audio_capturer_source.h index 621c392..ae60f91 100644 --- a/media/base/audio_capturer_source.h +++ b/media/base/audio_capturer_source.h @@ -30,7 +30,7 @@ class AudioCapturerSource bool key_pressed) = 0; // Signals an error has occurred. - virtual void OnCaptureError() = 0; + virtual void OnCaptureError(const std::string& message) = 0; protected: virtual ~CaptureCallback() {} |