Stop over-counting media decoder codec config src= UMAs

This change makes it more clear when exactly code that records
{Audio,Video}DecoderConfig UMA stats is to be done. Previously, it was
possible to record src= decoder config stats accidentally if using the
non-trivial config constructors. This at least included MSE and pepper shim
code paths, leading to double-counting configs in various cases
accidentally. There was also incorrect usage of Initialize()'s
|record_stats| parameter in at least some MSE code paths.

src= playback decoder config stats recording is now extracted
out of the decoder configs and AVStream converters and moved to
FFmpegDemuxer.

Known cases where we were incorrectly recording a src= codec config:
* MSE WebM audio initialization segment parsing
* MSE WebM video initialization segment parsing
* MSE MP2TS h264 es, mpeg1audio es, and adts es parsing
* DecryptingAudioDecoderTests (probably no impact of this)

BUG=522216
R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/1293853006

Cr-Commit-Position: refs/heads/master@{#344872}

1 files changed, 1 insertions, 2 deletions

diff --git a/media/base/video_decoder_config.h b/media/base/video_decoder_config.h
index 4a227c3..91ead43 100644
--- a/media/base/video_decoder_config.h
+++ b/media/base/video_decoder_config.h
@@ -101,8 +101,7 @@ class MEDIA_EXPORT VideoDecoderConfig {
                   const gfx::Size& natural_size,
                   const uint8* extra_data,
                   size_t extra_data_size,
-                  bool is_encrypted,
-                  bool record_stats);
+                  bool is_encrypted);
 
   // Returns true if this object has appropriate configuration values, false
   // otherwise.