summaryrefslogtreecommitdiffstats
path: root/media/base
diff options
context:
space:
mode:
authorajwong@chromium.org <ajwong@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-13 21:25:25 +0000
committerajwong@chromium.org <ajwong@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-13 21:25:25 +0000
commitb765033590fc4df1a4b42d0b82d78f7a6a8fc75e (patch)
tree86f2f77d0165cb0334ea6203520a5e5eacb10efd /media/base
parentdffeb89734143d57a09c96ae473552463fd579bb (diff)
downloadchromium_src-b765033590fc4df1a4b42d0b82d78f7a6a8fc75e.zip
chromium_src-b765033590fc4df1a4b42d0b82d78f7a6a8fc75e.tar.gz
chromium_src-b765033590fc4df1a4b42d0b82d78f7a6a8fc75e.tar.bz2
Small changes to comments and add host() + message_loop() implementation into MediaFilter.
Remove host() and message_loop() overrides in DecoderBase. Review URL: http://codereview.chromium.org/150193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20533 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/base')
-rw-r--r--media/base/filters.h3
-rw-r--r--media/base/pipeline_impl.cc10
2 files changed, 12 insertions, 1 deletions
diff --git a/media/base/filters.h b/media/base/filters.h
index 9fd1b2e..b892961 100644
--- a/media/base/filters.h
+++ b/media/base/filters.h
@@ -103,6 +103,9 @@ class MediaFilter : public base::RefCountedThreadSafe<MediaFilter> {
friend class base::RefCountedThreadSafe<MediaFilter>;
virtual ~MediaFilter() {}
+ FilterHost* host() const { return host_; }
+ MessageLoop* message_loop() const { return message_loop_; }
+
private:
FilterHost* host_;
MessageLoop* message_loop_;
diff --git a/media/base/pipeline_impl.cc b/media/base/pipeline_impl.cc
index 098fb18..9ba4181 100644
--- a/media/base/pipeline_impl.cc
+++ b/media/base/pipeline_impl.cc
@@ -26,9 +26,17 @@ bool SupportsSetMessageLoop() {
case FILTER_AUDIO_DECODER:
case FILTER_VIDEO_DECODER:
return true;
- default:
+
+ case FILTER_DATA_SOURCE:
+ case FILTER_AUDIO_RENDERER:
+ case FILTER_VIDEO_RENDERER:
return false;
+
+ // Skipping default case so compiler will warn on a missed enumeration.
}
+
+ NOTREACHED() << "Unexpected filter type " << Filter::filter_type();
+ return false;
}
// Small helper function to help us name filter threads for debugging.