diff options
author | mikhal@google.com <mikhal@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-19 19:51:56 +0000 |
---|---|---|
committer | mikhal@google.com <mikhal@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-19 19:51:56 +0000 |
commit | 58bc947c9f63ecd1070ef4dffdd88e7658615258 (patch) | |
tree | a3f52f698f023718abeda63d41c0962b2343c3b4 /media/cast/cast_sender_impl.cc | |
parent | 6787c5d9afc8fe956e8a85a07a1a85d7954f5fb0 (diff) | |
download | chromium_src-58bc947c9f63ecd1070ef4dffdd88e7658615258.zip chromium_src-58bc947c9f63ecd1070ef4dffdd88e7658615258.tar.gz chromium_src-58bc947c9f63ecd1070ef4dffdd88e7658615258.tar.bz2 |
Incorporating logging into Cast:
1. Adding logging to CastEnvironment.
2. Actually triggering logging within the cast library.
3. Adding thread checks.
4. Removing trace calls outside of the logging class.
Open issues:
1.Use of rtp_timestamp and frame id is not consistent.
In addition, the AudioBus does not include these values.
2. There is a pending cl to switch frame_id to int. This cl does not include that.
3. There are a few more places to add logging.
As this cl is already big enough, all of the above will come in a follow-up cl.
Review URL: https://codereview.chromium.org/69603002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236034 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/cast/cast_sender_impl.cc')
-rw-r--r-- | media/cast/cast_sender_impl.cc | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/media/cast/cast_sender_impl.cc b/media/cast/cast_sender_impl.cc index 1bdd7c5..d1a83d3 100644 --- a/media/cast/cast_sender_impl.cc +++ b/media/cast/cast_sender_impl.cc @@ -34,6 +34,9 @@ class LocalFrameInput : public FrameInput { virtual void InsertRawVideoFrame(const I420VideoFrame* video_frame, const base::TimeTicks& capture_time, const base::Closure callback) OVERRIDE { + cast_environment_->Logging()->InsertFrameEvent(kVideoFrameReceived, + GetVideoRtpTimestamp(capture_time), kFrameIdUnknown); + cast_environment_->PostTask(CastEnvironment::MAIN, FROM_HERE, base::Bind(&VideoSender::InsertRawVideoFrame, video_sender_, video_frame, capture_time, callback)); @@ -50,6 +53,8 @@ class LocalFrameInput : public FrameInput { virtual void InsertAudio(const AudioBus* audio_bus, const base::TimeTicks& recorded_time, const base::Closure& done_callback) OVERRIDE { + cast_environment_->Logging()->InsertFrameEvent(kAudioFrameReceived, + GetVideoRtpTimestamp(recorded_time), kFrameIdUnknown); cast_environment_->PostTask(CastEnvironment::MAIN, FROM_HERE, base::Bind(&AudioSender::InsertAudio, audio_sender_, audio_bus, recorded_time, done_callback)); |