diff options
| author | mikhal@google.com <mikhal@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-20 03:24:01 +0000 |
|---|---|---|
| committer | mikhal@google.com <mikhal@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-20 03:24:01 +0000 |
| commit | 7df9716b1c460092a3caca82dddfe78739940aa9 (patch) | |
| tree | a57328270dafca2b95affd5bc47e546f255ea66e /media/cast/test/encode_decode_test.cc | |
| parent | 7cc7a2e71c9b9dc1fe1d2cf67839ed8f00169bb1 (diff) | |
| download | chromium_src-7df9716b1c460092a3caca82dddfe78739940aa9.zip chromium_src-7df9716b1c460092a3caca82dddfe78739940aa9.tar.gz chromium_src-7df9716b1c460092a3caca82dddfe78739940aa9.tar.bz2 | |
Incorporating logging into Cast:
1. Adding logging to CastEnvironment.
2. Actually triggering logging within the cast library.
3. Adding thread checks.
4. Removing trace calls outside of the logging class.
Open issues:
1.Use of rtp_timestamp and frame id is not consistent.
In addition, the AudioBus does not include these values.
2. There is a pending cl to switch frame_id to int. This cl does not include that.
3. There are a few more places to add logging.
As this cl is already big enough, all of the above will come in a follow-up cl.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236034
Review URL: https://codereview.chromium.org/69603002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236118 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/cast/test/encode_decode_test.cc')
| -rw-r--r-- | media/cast/test/encode_decode_test.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/media/cast/test/encode_decode_test.cc b/media/cast/test/encode_decode_test.cc index 2775dcb..0cf8929 100644 --- a/media/cast/test/encode_decode_test.cc +++ b/media/cast/test/encode_decode_test.cc @@ -74,7 +74,7 @@ class EncodeDecodeTest : public ::testing::Test { // CastEnvironment will only be used by the vp8 decoder; Enable only the // video decoder and main threads. cast_environment_(new CastEnvironment(&testing_clock_, task_runner_, - NULL, NULL, NULL, task_runner_)), + NULL, NULL, NULL, task_runner_, GetDefaultCastLoggingConfig())), test_callback_(new EncodeDecodeTestFrameCallback()) { testing_clock_.Advance( base::TimeDelta::FromMilliseconds(kStartMillisecond)); |