media: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=dalecurtis@chromium.org, dcheng@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1731403002

Cr-Commit-Position: refs/heads/master@{#377967}

6 files changed, 15 insertions, 0 deletions

diff --git a/media/cast/cast_config.cc b/media/cast/cast_config.cc
index f3b1612..1a619fd 100644
--- a/media/cast/cast_config.cc
+++ b/media/cast/cast_config.cc
@@ -58,6 +58,8 @@ VideoSenderConfig::VideoSenderConfig()
       codec(CODEC_VIDEO_VP8),
       number_of_encode_threads(1) {}
 
+VideoSenderConfig::VideoSenderConfig(const VideoSenderConfig& other) = default;
+
 VideoSenderConfig::~VideoSenderConfig() {}
 
 AudioSenderConfig::AudioSenderConfig()
@@ -72,6 +74,8 @@ AudioSenderConfig::AudioSenderConfig()
       bitrate(kDefaultAudioEncoderBitrate),
       codec(CODEC_AUDIO_OPUS) {}
 
+AudioSenderConfig::AudioSenderConfig(const AudioSenderConfig& other) = default;
+
 AudioSenderConfig::~AudioSenderConfig() {}
 
 FrameReceiverConfig::FrameReceiverConfig()
@@ -84,6 +88,9 @@ FrameReceiverConfig::FrameReceiverConfig()
       target_frame_rate(0),
       codec(CODEC_UNKNOWN) {}
 
+FrameReceiverConfig::FrameReceiverConfig(const FrameReceiverConfig& other) =
+    default;
+
 FrameReceiverConfig::~FrameReceiverConfig() {}
 
 }  // namespace cast
diff --git a/media/cast/cast_config.h b/media/cast/cast_config.h
index e6a0a62..465f924 100644
--- a/media/cast/cast_config.h
+++ b/media/cast/cast_config.h
@@ -59,6 +59,7 @@ enum SuggestedDefaults {
 // http://crbug.com/530839
 struct AudioSenderConfig {
   AudioSenderConfig();
+  AudioSenderConfig(const AudioSenderConfig& other);
   ~AudioSenderConfig();
 
   // Identifier referring to the sender, used by the receiver.
@@ -97,6 +98,7 @@ struct AudioSenderConfig {
 
 struct VideoSenderConfig {
   VideoSenderConfig();
+  VideoSenderConfig(const VideoSenderConfig& other);
   ~VideoSenderConfig();
 
   // Identifier referring to the sender, used by the receiver.
@@ -163,6 +165,7 @@ struct VideoSenderConfig {
 // TODO(miu): Naming and minor type changes are badly needed in a later CL.
 struct FrameReceiverConfig {
   FrameReceiverConfig();
+  FrameReceiverConfig(const FrameReceiverConfig& other);
   ~FrameReceiverConfig();
 
   // The receiver's SSRC identifier.
diff --git a/media/cast/logging/logging_defines.cc b/media/cast/logging/logging_defines.cc
index c3c872a..22f326a 100644
--- a/media/cast/logging/logging_defines.cc
+++ b/media/cast/logging/logging_defines.cc
@@ -43,6 +43,7 @@ FrameEvent::FrameEvent()
       target_bitrate(0),
       encoder_cpu_utilization(-1.0),
       idealized_bitrate_utilization(-1.0) {}
+FrameEvent::FrameEvent(const FrameEvent& other) = default;
 FrameEvent::~FrameEvent() {}
 
 PacketEvent::PacketEvent()
diff --git a/media/cast/logging/logging_defines.h b/media/cast/logging/logging_defines.h
index 00425be..257652d 100644
--- a/media/cast/logging/logging_defines.h
+++ b/media/cast/logging/logging_defines.h
@@ -54,6 +54,7 @@ enum EventMediaType {
 
 struct FrameEvent {
   FrameEvent();
+  FrameEvent(const FrameEvent& other);
   ~FrameEvent();
 
   RtpTimeTicks rtp_timestamp;
diff --git a/media/cast/net/rtcp/rtcp_defines.cc b/media/cast/net/rtcp/rtcp_defines.cc
index b4f363e..f7a1a6c 100644
--- a/media/cast/net/rtcp/rtcp_defines.cc
+++ b/media/cast/net/rtcp/rtcp_defines.cc
@@ -21,6 +21,8 @@ RtcpReceiverEventLogMessage::~RtcpReceiverEventLogMessage() {}
 
 RtcpReceiverFrameLogMessage::RtcpReceiverFrameLogMessage(RtpTimeTicks timestamp)
     : rtp_timestamp_(timestamp) {}
+RtcpReceiverFrameLogMessage::RtcpReceiverFrameLogMessage(
+    const RtcpReceiverFrameLogMessage& other) = default;
 RtcpReceiverFrameLogMessage::~RtcpReceiverFrameLogMessage() {}
 
 RtcpReceiverReferenceTimeReport::RtcpReceiverReferenceTimeReport()
diff --git a/media/cast/net/rtcp/rtcp_defines.h b/media/cast/net/rtcp/rtcp_defines.h
index 69a81bf..98d69bb 100644
--- a/media/cast/net/rtcp/rtcp_defines.h
+++ b/media/cast/net/rtcp/rtcp_defines.h
@@ -69,6 +69,7 @@ typedef std::list<RtcpReceiverEventLogMessage> RtcpReceiverEventLogMessages;
 
 struct RtcpReceiverFrameLogMessage {
   explicit RtcpReceiverFrameLogMessage(RtpTimeTicks rtp_timestamp);
+  RtcpReceiverFrameLogMessage(const RtcpReceiverFrameLogMessage& other);
   ~RtcpReceiverFrameLogMessage();
 
   const RtpTimeTicks rtp_timestamp_;