summaryrefslogtreecommitdiffstats
path: root/media/formats
diff options
context:
space:
mode:
authorvmpstr <vmpstr@chromium.org>2016-02-26 12:49:07 -0800
committerCommit bot <commit-bot@chromium.org>2016-02-26 20:50:19 +0000
commit9750c9d9a4b7c8b84716facbf16c735ae9b355bf (patch)
tree9393c9ba347b5499b403c87eaed31e02b91bd673 /media/formats
parent60c10a4ce69ac02dd77c3616e95d2d4f99bd6a29 (diff)
downloadchromium_src-9750c9d9a4b7c8b84716facbf16c735ae9b355bf.zip
chromium_src-9750c9d9a4b7c8b84716facbf16c735ae9b355bf.tar.gz
chromium_src-9750c9d9a4b7c8b84716facbf16c735ae9b355bf.tar.bz2
media: Add out-of-line copy ctors for complex classes.
This patch adds out of line copy constructors for classes that our clang-plugin considers heavy. This is an effort to enable copy constructor checks by default. BUG=436357 R=dalecurtis@chromium.org, dcheng@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/1731403002 Cr-Commit-Position: refs/heads/master@{#377967}
Diffstat (limited to 'media/formats')
-rw-r--r--media/formats/webm/tracks_builder.cc2
-rw-r--r--media/formats/webm/tracks_builder.h1
-rw-r--r--media/formats/webm/webm_cluster_parser.cc2
-rw-r--r--media/formats/webm/webm_cluster_parser.h1
4 files changed, 6 insertions, 0 deletions
diff --git a/media/formats/webm/tracks_builder.cc b/media/formats/webm/tracks_builder.cc
index 6b2aaea..458f522 100644
--- a/media/formats/webm/tracks_builder.cc
+++ b/media/formats/webm/tracks_builder.cc
@@ -294,6 +294,8 @@ TracksBuilder::Track::Track(int track_num,
}
}
+TracksBuilder::Track::Track(const Track& other) = default;
+
int TracksBuilder::Track::GetSize() const {
return MasterElementSize(kWebMIdTrackEntry, GetPayloadSize());
}
diff --git a/media/formats/webm/tracks_builder.h b/media/formats/webm/tracks_builder.h
index dc0283e..41d0938 100644
--- a/media/formats/webm/tracks_builder.h
+++ b/media/formats/webm/tracks_builder.h
@@ -83,6 +83,7 @@ class TracksBuilder {
int audio_channels,
double audio_sampling_frequency,
bool allow_invalid_values);
+ Track(const Track& other);
int GetSize() const;
void Write(uint8_t** buf, int* buf_size) const;
diff --git a/media/formats/webm/webm_cluster_parser.cc b/media/formats/webm/webm_cluster_parser.cc
index e4fb5bb..21c1895 100644
--- a/media/formats/webm/webm_cluster_parser.cc
+++ b/media/formats/webm/webm_cluster_parser.cc
@@ -598,6 +598,8 @@ WebMClusterParser::Track::Track(int track_num,
default_duration_ > base::TimeDelta());
}
+WebMClusterParser::Track::Track(const Track& other) = default;
+
WebMClusterParser::Track::~Track() {}
DecodeTimestamp WebMClusterParser::Track::GetReadyUpperBound() {
diff --git a/media/formats/webm/webm_cluster_parser.h b/media/formats/webm/webm_cluster_parser.h
index 3976cfa..c719515 100644
--- a/media/formats/webm/webm_cluster_parser.h
+++ b/media/formats/webm/webm_cluster_parser.h
@@ -55,6 +55,7 @@ class MEDIA_EXPORT WebMClusterParser : public WebMParserClient {
bool is_video,
base::TimeDelta default_duration,
const scoped_refptr<MediaLog>& media_log);
+ Track(const Track& other);
~Track();
int track_num() const { return track_num_; }