summaryrefslogtreecommitdiffstats
path: root/media/mojo
diff options
context:
space:
mode:
authorxhwang <xhwang@chromium.org>2016-03-03 16:09:12 -0800
committerCommit bot <commit-bot@chromium.org>2016-03-04 00:10:21 +0000
commit1cfe194c3f0342f61c98331aef92cfad9b8f6393 (patch)
tree3d759c7a9ff11918ac3dd5f603d53c3b93b618cf /media/mojo
parent0e9db0caab3ab7d2887722c892c049fe80ecab29 (diff)
downloadchromium_src-1cfe194c3f0342f61c98331aef92cfad9b8f6393.zip
chromium_src-1cfe194c3f0342f61c98331aef92cfad9b8f6393.tar.gz
chromium_src-1cfe194c3f0342f61c98331aef92cfad9b8f6393.tar.bz2
media: Minor comments cleanup in MojoMediaClient.
BUG=586211 TEST=No functionality change. Review URL: https://codereview.chromium.org/1767463002 Cr-Commit-Position: refs/heads/master@{#379148}
Diffstat (limited to 'media/mojo')
-rw-r--r--media/mojo/services/mojo_media_client.h15
1 files changed, 10 insertions, 5 deletions
diff --git a/media/mojo/services/mojo_media_client.h b/media/mojo/services/mojo_media_client.h
index 84267be..9b69c10 100644
--- a/media/mojo/services/mojo_media_client.h
+++ b/media/mojo/services/mojo_media_client.h
@@ -31,13 +31,18 @@ class MojoMediaClient {
// Called exactly once before any other method.
virtual void Initialize();
- // Returns the RendererFactory to be used by MojoRendererService. If returns
- // null, a RendererImpl will be used with audio/video decoders provided in
- // CreateAudioDecoders() and CreateVideoDecoders().
+
+ // TODO(xhwang): Consider creating Renderer and CDM directly in the client
+ // instead of creating factories. See http://crbug.com/586211
+
+ // Returns the RendererFactory to be used by MojoRendererService.
virtual scoped_ptr<RendererFactory> CreateRendererFactory(
const scoped_refptr<MediaLog>& media_log);
- // The output sink used for rendering audio or video respectively. These
- // sinks must be owned by the client.
+
+ // The output sink used for rendering audio or video respectively. They will
+ // be used in the CreateRenderer() call on the RendererFactory returned by
+ // CreateRendererFactory(). May be null if the RendererFactory doesn't need an
+ // audio or video sink. If not null, the sink must be owned by the client.
virtual AudioRendererSink* CreateAudioRendererSink();
virtual VideoRendererSink* CreateVideoRendererSink(
const scoped_refptr<base::SingleThreadTaskRunner>& task_runner);