summaryrefslogtreecommitdiffstats
path: root/media/renderers/renderer_impl_unittest.cc
diff options
context:
space:
mode:
authora.berwal <a.berwal@samsung.com>2015-04-22 04:14:50 -0700
committerCommit bot <commit-bot@chromium.org>2015-04-22 11:15:03 +0000
commit338bf0048faab4c20b0767620c524b9636c31a04 (patch)
tree9658711dd7bb9040958ad653a6a9c07f5a12376e /media/renderers/renderer_impl_unittest.cc
parent8636595314c3d46ca4edf53d67403dad56998209 (diff)
downloadchromium_src-338bf0048faab4c20b0767620c524b9636c31a04.zip
chromium_src-338bf0048faab4c20b0767620c524b9636c31a04.tar.gz
chromium_src-338bf0048faab4c20b0767620c524b9636c31a04.tar.bz2
Switch to double for time calculations using playback rate.
Multiplying an int64 against a float causes the float type to prevail which does not have enough precision for accurate time value computations. BUG= 475964 TBR=lcwu1, gunsch Review URL: https://codereview.chromium.org/1094783002 Cr-Commit-Position: refs/heads/master@{#326269}
Diffstat (limited to 'media/renderers/renderer_impl_unittest.cc')
-rw-r--r--media/renderers/renderer_impl_unittest.cc10
1 files changed, 5 insertions, 5 deletions
diff --git a/media/renderers/renderer_impl_unittest.cc b/media/renderers/renderer_impl_unittest.cc
index 9fcefe4..df4c8cc 100644
--- a/media/renderers/renderer_impl_unittest.cc
+++ b/media/renderers/renderer_impl_unittest.cc
@@ -217,7 +217,7 @@ class RendererImplTest : public ::testing::Test {
base::RunLoop().RunUntilIdle();
}
- void SetPlaybackRate(float playback_rate) {
+ void SetPlaybackRate(double playback_rate) {
EXPECT_CALL(time_source_, SetPlaybackRate(playback_rate));
renderer_impl_->SetPlaybackRate(playback_rate);
base::RunLoop().RunUntilIdle();
@@ -227,7 +227,7 @@ class RendererImplTest : public ::testing::Test {
return renderer_impl_->GetMediaTime().InMilliseconds();
}
- bool IsMediaTimeAdvancing(float playback_rate) {
+ bool IsMediaTimeAdvancing(double playback_rate) {
int64 start_time_ms = GetMediaTimeMs();
const int64 time_to_advance_ms = 100;
@@ -242,7 +242,7 @@ class RendererImplTest : public ::testing::Test {
}
bool IsMediaTimeAdvancing() {
- return IsMediaTimeAdvancing(1.0f);
+ return IsMediaTimeAdvancing(1.0);
}
// Fixture members.
@@ -377,8 +377,8 @@ TEST_F(RendererImplTest, FlushAfterUnderflow) {
TEST_F(RendererImplTest, SetPlaybackRate) {
InitializeWithAudioAndVideo();
- SetPlaybackRate(1.0f);
- SetPlaybackRate(2.0f);
+ SetPlaybackRate(1.0);
+ SetPlaybackRate(2.0);
}
TEST_F(RendererImplTest, SetVolume) {