diff options
| author | imasaki@google.com <imasaki@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-02 21:07:50 +0000 |
|---|---|---|
| committer | imasaki@google.com <imasaki@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-02 21:07:50 +0000 |
| commit | cf21ad53d49316fde798c3dcce6ff319430bcfaf (patch) | |
| tree | 7d954230303a82dc5cb43389377656d0ac242266 /media/tools/layout_tests | |
| parent | 16fc3e6cd92201dd38df4cfb5ab3cf1f8c37c3f5 (diff) | |
| download | chromium_src-cf21ad53d49316fde798c3dcce6ff319430bcfaf.zip chromium_src-cf21ad53d49316fde798c3dcce6ff319430bcfaf.tar.gz chromium_src-cf21ad53d49316fde798c3dcce6ff319430bcfaf.tar.bz2 | |
Fix a bug that shows incorrect revision author/message in the layout test
analyzer. Previously, analyzer's email shows previous revision author/message.
Updated to show current author/message. Also added some comments and renames variables to avoid confusion. The fix is verified using integration
environment.
Review URL: http://codereview.chromium.org/7552013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95156 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/tools/layout_tests')
| -rwxr-xr-x | media/tools/layout_tests/test_expectations.py | 20 |
1 files changed, 11 insertions, 9 deletions
diff --git a/media/tools/layout_tests/test_expectations.py b/media/tools/layout_tests/test_expectations.py index c47d653..81041a9 100755 --- a/media/tools/layout_tests/test_expectations.py +++ b/media/tools/layout_tests/test_expectations.py @@ -412,16 +412,18 @@ class TestExpectationsManager(object): pysvn.opt_revision_kind.date, end)) result_list = [] for i in xrange(len(logs) - 1): - rev1 = logs[i].revision.number - rev2 = logs[i + 1].revision.number - author = logs[i + 1].author - date = logs[i + 1].date - message = logs[i + 1].message + # PySVN.log returns logs in reverse chronological order. + new_rev = logs[i].revision.number + old_rev = logs[i + 1].revision.number + # Getting information about new revision. + author = logs[i].author + date = logs[i].date + message = logs[i].message text = client.diff('/tmp', 'tmp/test_expectations.txt', revision1=pysvn.Revision( - pysvn.opt_revision_kind.number, rev2), + pysvn.opt_revision_kind.number, old_rev), revision2=pysvn.Revision( - pysvn.opt_revision_kind.number, rev1)) + pysvn.opt_revision_kind.number, new_rev)) lines = text.split('\n') for line in lines: for pattern in patterns: @@ -430,10 +432,10 @@ class TestExpectationsManager(object): if checkchange: if ((line[0] == '+' and change > 0) or (line[0] == '-' and change < 0)): - result_list.append((rev2, rev1, line, + result_list.append((old_rev, new_rev, line, author, date, message)) else: if line[0] == '+' or line[0] == '-': - result_list.append((rev2, rev1, line, + result_list.append((old_rev, new_rev, line, author, date, message)) return result_list |