diff options
author | dcheng <dcheng@chromium.org> | 2015-11-18 23:00:20 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-11-19 07:01:23 +0000 |
commit | 0917ec4328dc20b59887d78f76b9f075e12e5f7f (patch) | |
tree | e2e24def30f3b6619eb1b92d570b055bfcef9672 /media/video | |
parent | d076ca806251e4b636b421eb46ca04d14366b2cc (diff) | |
download | chromium_src-0917ec4328dc20b59887d78f76b9f075e12e5f7f.zip chromium_src-0917ec4328dc20b59887d78f76b9f075e12e5f7f.tar.gz chromium_src-0917ec4328dc20b59887d78f76b9f075e12e5f7f.tar.bz2 |
Use std::default_delete as the default deleter for scoped_ptr.
The aim is to make scoped_ptr and std::unique_ptr functionally
identical so scoped_ptr can simply be a typedef.
BUG=554298
Review URL: https://codereview.chromium.org/1445003002
Cr-Commit-Position: refs/heads/master@{#360539}
Diffstat (limited to 'media/video')
-rw-r--r-- | media/video/video_decode_accelerator.cc | 13 | ||||
-rw-r--r-- | media/video/video_decode_accelerator.h | 15 | ||||
-rw-r--r-- | media/video/video_encode_accelerator.cc | 12 | ||||
-rw-r--r-- | media/video/video_encode_accelerator.h | 15 |
4 files changed, 22 insertions, 33 deletions
diff --git a/media/video/video_decode_accelerator.cc b/media/video/video_decode_accelerator.cc index 0c6b2b9..7449a2a 100644 --- a/media/video/video_decode_accelerator.cc +++ b/media/video/video_decode_accelerator.cc @@ -38,14 +38,11 @@ VideoDecodeAccelerator::SupportedProfile::~SupportedProfile() { } // namespace media -namespace base { +namespace std { -void DefaultDeleter<media::VideoDecodeAccelerator>::operator()( - void* video_decode_accelerator) const { - static_cast<media::VideoDecodeAccelerator*>(video_decode_accelerator)-> - Destroy(); +void default_delete<media::VideoDecodeAccelerator>::operator()( + media::VideoDecodeAccelerator* vda) const { + vda->Destroy(); } -} // namespace base - - +} // namespace std diff --git a/media/video/video_decode_accelerator.h b/media/video/video_decode_accelerator.h index a53e352..e2bcdf6 100644 --- a/media/video/video_decode_accelerator.h +++ b/media/video/video_decode_accelerator.h @@ -5,6 +5,7 @@ #ifndef MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_ #define MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_ +#include <memory> #include <vector> #include "base/basictypes.h" @@ -190,19 +191,15 @@ class MEDIA_EXPORT VideoDecodeAccelerator { } // namespace media -namespace base { +namespace std { -template <class T> -struct DefaultDeleter; - -// Specialize DefaultDeleter so that scoped_ptr<VideoDecodeAccelerator> always +// Specialize std::default_delete so that scoped_ptr<VideoDecodeAccelerator> // uses "Destroy()" instead of trying to use the destructor. template <> -struct MEDIA_EXPORT DefaultDeleter<media::VideoDecodeAccelerator> { - public: - void operator()(void* video_decode_accelerator) const; +struct MEDIA_EXPORT default_delete<media::VideoDecodeAccelerator> { + void operator()(media::VideoDecodeAccelerator* vda) const; }; -} // namespace base +} // namespace std #endif // MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_ diff --git a/media/video/video_encode_accelerator.cc b/media/video/video_encode_accelerator.cc index dccd31d..51a4a7b 100644 --- a/media/video/video_encode_accelerator.cc +++ b/media/video/video_encode_accelerator.cc @@ -19,13 +19,11 @@ VideoEncodeAccelerator::SupportedProfile::~SupportedProfile() { } // namespace media -namespace base { +namespace std { -void DefaultDeleter<media::VideoEncodeAccelerator>::operator()( - void* video_encode_accelerator) const { - static_cast<media::VideoEncodeAccelerator*>(video_encode_accelerator)-> - Destroy(); +void default_delete<media::VideoEncodeAccelerator>::operator()( + media::VideoEncodeAccelerator* vea) const { + vea->Destroy(); } -} // namespace base - +} // namespace std diff --git a/media/video/video_encode_accelerator.h b/media/video/video_encode_accelerator.h index 6879b0d..39ad0b7 100644 --- a/media/video/video_encode_accelerator.h +++ b/media/video/video_encode_accelerator.h @@ -5,6 +5,7 @@ #ifndef MEDIA_VIDEO_VIDEO_ENCODE_ACCELERATOR_H_ #define MEDIA_VIDEO_VIDEO_ENCODE_ACCELERATOR_H_ +#include <memory> #include <vector> #include "base/basictypes.h" @@ -155,19 +156,15 @@ class MEDIA_EXPORT VideoEncodeAccelerator { } // namespace media -namespace base { +namespace std { -template <class T> -struct DefaultDeleter; - -// Specialize DefaultDeleter so that scoped_ptr<VideoEncodeAccelerator> always +// Specialize std::default_delete so that scoped_ptr<VideoEncodeAccelerator> // uses "Destroy()" instead of trying to use the destructor. template <> -struct MEDIA_EXPORT DefaultDeleter<media::VideoEncodeAccelerator> { - public: - void operator()(void* video_encode_accelerator) const; +struct MEDIA_EXPORT default_delete<media::VideoEncodeAccelerator> { + void operator()(media::VideoEncodeAccelerator* vea) const; }; -} // namespace base +} // namespace std #endif // MEDIA_VIDEO_VIDEO_ENCODE_ACCELERATOR_H_ |