Make VideoDecoderConfig copyable.

I guess the reasons we didn't make VideoDecoderConfig copyable is:
1) VideoDecoderConfig contains extra data, which needs deep copy.
2) We don't have a lot of use cases that needs to copy VideoDecoderConfig. If we
do, we can use CopyFrom().

For (1), the extra data is typically small (< 100 bytes). Copying extra data
should not have any performance impact.

For (2), we do have legitimate cases where we need to copy VideoDecoderConfig
implicitly:
- Put VideoDecoderConfig in STL container, e.g. in SourceBufferStream.
- Bind VideoDecoderCongfig in a callback, e.g. in DecryptingVideoDecoder.

This CL uses std::vector<uint8> for the extra data and solves the deep copy
issue. Then it makes VideoDecoderConfig copyable and makes several use cases of
VideoDecoderConfig simpler.

BUG=177543
TEST=All tests pass.


Review URL: https://chromiumcodereview.appspot.com/12637017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187702 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 1 insertions, 1 deletions

diff --git a/media/webm/webm_stream_parser.cc b/media/webm/webm_stream_parser.cc
index db854a9..ca7ec30 100644
--- a/media/webm/webm_stream_parser.cc
+++ b/media/webm/webm_stream_parser.cc
@@ -384,7 +384,7 @@ int WebMStreamParser::ParseInfoAndTracks(const uint8* data, int size) {
 
     FireNeedKey(tracks_parser.video_encryption_key_id());
   } else {
-    video_config.CopyFrom(config_helper.video_config());
+    video_config = config_helper.video_config();
   }
 
   if (!config_cb_.Run(audio_config, video_config)) {