diff options
| author | dpranke <dpranke@chromium.org> | 2016-02-03 08:57:44 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-02-03 16:59:37 +0000 |
| commit | 002f2226477126a477d38086b119073911fa231d (patch) | |
| tree | af82ceffc1a92388390867d474e90f4c0073771d /media | |
| parent | 761098fba97c6ec094e241b61ecf879134ab7922 (diff) | |
| download | chromium_src-002f2226477126a477d38086b119073911fa231d.zip chromium_src-002f2226477126a477d38086b119073911fa231d.tar.gz chromium_src-002f2226477126a477d38086b119073911fa231d.tar.bz2 | |
Revert of Move gn _run target generation into test(). (patchset #1 id:1 of https://codereview.chromium.org/1653003006/ )
Reason for revert:
Broke angle_unittests_run, which doesn't follow the template:
https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/builds/53646/steps/compile/logs/stdio
Original issue's description:
> Move gn _run target generation into test().
>
> TBR=brettw@chromium.org
> BUG=
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/6b1b03783b81ea27bb521c02aa84b74f06d6f71a
> Cr-Commit-Position: refs/heads/master@{#373232}
TBR=phosek@chromium.org,brettw@chromium.org,jbudorick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1664653003
Cr-Commit-Position: refs/heads/master@{#373257}
Diffstat (limited to 'media')
| -rw-r--r-- | media/BUILD.gn | 18 | ||||
| -rw-r--r-- | media/blink/BUILD.gn | 9 | ||||
| -rw-r--r-- | media/cast/BUILD.gn | 9 | ||||
| -rw-r--r-- | media/midi/BUILD.gn | 9 |
4 files changed, 45 insertions, 0 deletions
diff --git a/media/BUILD.gn b/media/BUILD.gn index b4d05e5..e8c0a87 100644 --- a/media/BUILD.gn +++ b/media/BUILD.gn @@ -610,6 +610,15 @@ if (is_ios) { } } +# TODO(GYP): Delete this after we've converted everything to GN. +# The _run targets exist only for compatibility w/ GYP. +group("media_unittests_run") { + testonly = true + deps = [ + ":media_unittests", + ] +} + test("media_unittests") { sources = [ "capture/content/animated_content_sampler_unittest.cc", @@ -830,6 +839,15 @@ test("media_perftests") { } } +# TODO(GYP): Delete this after we've converted everything to GN. +# The _run targets exist only for compatibility w/ GYP. +group("audio_unittests_run") { + testonly = true + deps = [ + ":audio_unittests", + ] +} + # For running the subset of media_unittests that might require audio hardware # separately on GPU bots. media_unittests includes these too. test("audio_unittests") { diff --git a/media/blink/BUILD.gn b/media/blink/BUILD.gn index daa405f..31140ce 100644 --- a/media/blink/BUILD.gn +++ b/media/blink/BUILD.gn @@ -154,3 +154,12 @@ test("media_blink_unittests") { configs += [ "//v8:external_startup_data" ] } + +# TODO(GYP): Delete this after we've converted everything to GN. +# The _run targets exist only for compatibility w/ GYP. +group("media_blink_unittests_run") { + testonly = true + deps = [ + ":media_blink_unittests", + ] +} diff --git a/media/cast/BUILD.gn b/media/cast/BUILD.gn index 10dfc2e..92aa84e 100644 --- a/media/cast/BUILD.gn +++ b/media/cast/BUILD.gn @@ -299,6 +299,15 @@ static_library("test_support") { } } +# TODO(GYP): Delete this after we've converted everything to GN. +# The _run targets exist only for compatibility w/ GYP. +group("cast_unittests_run") { + testonly = true + deps = [ + ":cast_unittests", + ] +} + test("cast_unittests") { sources = [ "common/expanded_value_base_unittest.cc", diff --git a/media/midi/BUILD.gn b/media/midi/BUILD.gn index 1f9a433..59a8e9c 100644 --- a/media/midi/BUILD.gn +++ b/media/midi/BUILD.gn @@ -150,6 +150,15 @@ component("midi") { } } +# TODO(GYP): Delete this after we've converted everything to GN. +# The _run targets exist only for compatibility w/ GYP. +group("midi_unittests_run") { + testonly = true + deps = [ + ":midi_unittests", + ] +} + test("midi_unittests") { sources = [ "midi_manager_unittest.cc", |