diff options
author | tfarina <tfarina@chromium.org> | 2015-04-29 07:12:58 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-04-29 14:13:28 +0000 |
commit | 57d7cbe499248a6ce91ff5b0c954da634cba713c (patch) | |
tree | 1996b97c22ff3f49651c1f9cff122a6540fc5667 /media | |
parent | f5e16ca669b193d696d5b90c9ff3515a89248412 (diff) | |
download | chromium_src-57d7cbe499248a6ce91ff5b0c954da634cba713c.zip chromium_src-57d7cbe499248a6ce91ff5b0c954da634cba713c.tar.gz chromium_src-57d7cbe499248a6ce91ff5b0c954da634cba713c.tar.bz2 |
media/midi: Fix warnings found by clang chromium-style plugin on Windows.
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/631/steps/compile/logs/stdio
This fixes the following kind or warnings:
warning(clang): [chromium-style] Complex constructor has an inlined body.
warning(clang): [chromium-style] Complex destructor has an inline body.
After this, "Complex constructor" warnings will be gone, assuming more does
not crap in.
BUG=467287
R=thakis@chromium.org,toyoshim@chromium.org
Review URL: https://codereview.chromium.org/1117603002
Cr-Commit-Position: refs/heads/master@{#327486}
Diffstat (limited to 'media')
-rw-r--r-- | media/midi/midi_manager_win.cc | 7 | ||||
-rw-r--r-- | media/midi/midi_manager_win.h | 4 |
2 files changed, 9 insertions, 2 deletions
diff --git a/media/midi/midi_manager_win.cc b/media/midi/midi_manager_win.cc index a911ff6..5937278 100644 --- a/media/midi/midi_manager_win.cc +++ b/media/midi/midi_manager_win.cc @@ -1093,6 +1093,13 @@ class MidiServiceWinImpl : public MidiServiceWin, } // namespace +MidiManagerWin::MidiManagerWin() { +} + +MidiManagerWin::~MidiManagerWin() { + midi_service_.reset(); +} + void MidiManagerWin::StartInitialization() { midi_service_.reset(new MidiServiceWinImpl); // Note that |CompleteInitialization()| will be called from the callback. diff --git a/media/midi/midi_manager_win.h b/media/midi/midi_manager_win.h index 73c1fe5..eef70eb 100644 --- a/media/midi/midi_manager_win.h +++ b/media/midi/midi_manager_win.h @@ -41,8 +41,8 @@ class MidiServiceWin { class MidiManagerWin final : public MidiManager, public MidiServiceWinDelegate { public: - MidiManagerWin() {} - ~MidiManagerWin() override { midi_service_.reset(); } + MidiManagerWin(); + ~MidiManagerWin() override; // MidiManager overrides: void StartInitialization() final; |