Move ProvidePictureBuffers out of initialization and into the decode path.

This is required for various reasons:
- Clients don't necessarily know the dimensions of the video they feed to the
  decoder.  It's the decoder's job to figure it out from the encoded stream, but
  it only gets a crack at that once Decode() is called, after initialization is
  done.
- PPAPI plugins get to call PPB_* functions at will, which means that (to avoid
  having to code re-entrancy into everything on the browser side) PPB_*
  functions aren't allowed to call into PPP_* functions.  So the previous call
  sequence of Initialize->ProvidePictureBuffers->CreateTextures would deadlock
  (requiring plugins to pre-create any textures they were going to get asked for
  in the future).

Also a bit of minor cleanup & added TODOs for future cleanup, and changed
GetConfigs()' signature to match the PPAPI version of itself (return bool
instead of void).

BUG=none
TEST=OVDATest passes on kaen.

Review URL: http://codereview.chromium.org/7147006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89251 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 5 insertions, 2 deletions

diff --git a/media/video/video_decode_accelerator.h b/media/video/video_decode_accelerator.h
index 032ee24..c50da97 100644
--- a/media/video/video_decode_accelerator.h
+++ b/media/video/video_decode_accelerator.h
@@ -229,14 +229,17 @@ class VideoDecodeAccelerator {
   };
 
   // Video decoder functions.
+
   // GetConfigs returns the supported configurations that is a subset of the
-  // given |requested_configs|.
+  // given |requested_configs|.  Unrecognized or malformed |requested_configs|
+  // elements return false and represent a failure; the client must not pass
+  // unknown request elements to Initialize.
   // Parameters:
   //  |requested_configs| is the set of configurations the plugin is querying
   //  for support.
   //  |matched_configs| is the subset of |requested_configs| that the decoder
   //  supports.
-  virtual void GetConfigs(
+  virtual bool GetConfigs(
       const std::vector<uint32>& requested_configs,
       std::vector<uint32>* matched_configs) = 0;