diff options
author | yzshen <yzshen@chromium.org> | 2016-01-27 17:30:14 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-01-28 02:04:50 +0000 |
commit | dca229ec9a69564985d182a16c9f2068db4d1989 (patch) | |
tree | 8a24a0dcb9fc23baabd739da253ac40ec436950a /mojo/android/javatests/src | |
parent | 95b810566de876251114b4b11827b093b8d05f11 (diff) | |
download | chromium_src-dca229ec9a69564985d182a16c9f2068db4d1989.zip chromium_src-dca229ec9a69564985d182a16c9f2068db4d1989.tar.gz chromium_src-dca229ec9a69564985d182a16c9f2068db4d1989.tar.bz2 |
Mojo C++ bindings: support enum validation.
By default, enums are not extensible, which means any unknown value will fail validation. If an enum may grow in the future, it needs to have [Extensible=True] attribute specified. In that case, the user code is responsible for handling unknown values properly.
This CL doesn't add corresponding validation for JS or Java.
BUG=404186
Review URL: https://codereview.chromium.org/1618963006
Cr-Commit-Position: refs/heads/master@{#371954}
Diffstat (limited to 'mojo/android/javatests/src')
-rw-r--r-- | mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java b/mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java index 286566d..2989170 100644 --- a/mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java +++ b/mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java @@ -59,6 +59,11 @@ public class ValidationTest extends MojoTestCase { if (pathname.getName().startsWith("conformance_mthd13_good_2")) { return false; } + // TODO(yzshen): skip enum validation tests because the feature is + // not supported in Java yet. crbug.com/581392 + if (pathname.getName().indexOf("enum") != -1) { + return false; + } return pathname.isFile() && pathname.getName().startsWith(mPrefix) && pathname.getName().endsWith(".data"); } |