Revert of Mojo: add javascript bindings for request/response (https://codereview.chromium.org/207503004/)

Reason for revert:
broke WebUIMojoTest.EndToEnd test.
http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/35528/steps/content_browsertests/logs/EndToEnd


Original issue's description:
> Mojo: add javascript bindings for request/response
> 
> If a mojom interface method specifies response parameters, then we'll generate javascript bindings that provide an additional callback parameter used to pass the response parameters. This mirrors the C++ implementation.
> 
> A future improvement will likely be to use promises instead, especially now that they are enabled on trunk.
> 
> As part of this CL, connector.js was also made consistent with connector.cc. It starts reading the message pipe immediately, handles write failures in a similar fashion, etc.
> 
> The Connection type from connector.js is factored out into a separate file as it now holds a Router object. router.js mirrors router.cc. The Connection type is really the mirror of the C++ RemotePtr<S> type.
> 
> Some basic request/response tests were added to connection_unittests.js. We'll probably want more testing.
> 
> R=abarth@chromium.org, mpcomplete@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259932

TBR=mpcomplete@chromium.org,abarth@chromium.org,darin@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/215883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260043 0039d316-1c4b-4281-b951-d872f2087c98

2 files changed, 132 insertions, 237 deletions

diff --git a/mojo/apps/js/bindings/connection_unittests.js b/mojo/apps/js/bindings/connection_unittests.js
deleted file mode 100644
index 14bb92f..0000000
--- a/mojo/apps/js/bindings/connection_unittests.js
+++ /dev/null
@@ -1,237 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-// Mock out the support module to avoid depending on the message loop.
-define("mojo/bindings/js/support", function() {
-  var waitingCallbacks = [];
-
-  function WaitCookie(id) {
-    this.id = id;
-  }
-
-  function asyncWait(handle, flags, callback) {
-    var id = waitingCallbacks.length;
-    waitingCallbacks.push(callback);
-    return new WaitCookie(id);
-  }
-
-  function cancelWait(cookie) {
-    waitingCallbacks[cookie.id] = null;
-  }
-
-  function numberOfWaitingCallbacks() {
-    var count = 0;
-    for (var i = 0; i < waitingCallbacks.length; ++i) {
-      if (waitingCallbacks[i])
-        ++count;
-    }
-    return count;
-  }
-
-  function pumpOnce(result) {
-    var callbacks = waitingCallbacks;
-    waitingCallbacks = [];
-    for (var i = 0; i < callbacks.length; ++i) {
-      if (callbacks[i])
-        callbacks[i](result);
-    }
-  }
-
-  var exports = {};
-  exports.asyncWait = asyncWait;
-  exports.cancelWait = cancelWait;
-  exports.numberOfWaitingCallbacks = numberOfWaitingCallbacks;
-  exports.pumpOnce = pumpOnce;
-  return exports;
-});
-
-define([
-    "gin/test/expect",
-    "mojo/bindings/js/support",
-    "mojo/bindings/js/core",
-    "mojo/public/bindings/js/connection",
-    "mojo/public/bindings/tests/sample_interfaces.mojom",
-    "mojo/public/bindings/tests/sample_service.mojom",
-], function(expect,
-            mockSupport,
-            core,
-            connection,
-            sample_interfaces,
-            sample_service) {
-  testClientServer();
-  testWriteToClosedPipe();
-  testRequestResponse();
-  this.result = "PASS";
-
-  function testClientServer() {
-    var receivedFrobinate = false;
-    var receivedDidFrobinate = false;
-
-    // ServiceImpl -------------------------------------------------------------
-
-    function ServiceImpl(peer) {
-      this.peer = peer;
-    }
-
-    ServiceImpl.prototype = Object.create(sample_service.ServiceStub.prototype);
-
-    ServiceImpl.prototype.frobinate = function(foo, baz, port) {
-      receivedFrobinate = true;
-
-      expect(foo.name).toBe("Example name");
-      expect(baz).toBeTruthy();
-      expect(core.close(port)).toBe(core.RESULT_OK);
-
-      this.peer.didFrobinate(42);
-    };
-
-    // ServiceImpl -------------------------------------------------------------
-
-    function ServiceClientImpl(peer) {
-      this.peer = peer;
-    }
-
-    ServiceClientImpl.prototype =
-        Object.create(sample_service.ServiceClientStub.prototype);
-
-    ServiceClientImpl.prototype.didFrobinate = function(result) {
-      receivedDidFrobinate = true;
-
-      expect(result).toBe(42);
-    };
-
-    var pipe = core.createMessagePipe();
-    var anotherPipe = core.createMessagePipe();
-    var sourcePipe = core.createMessagePipe();
-
-    var connection0 = new connection.Connection(
-        pipe.handle0, ServiceImpl, sample_service.ServiceClientProxy);
-
-    var connection1 = new connection.Connection(
-        pipe.handle1, ServiceClientImpl, sample_service.ServiceProxy);
-
-    var foo = new sample_service.Foo();
-    foo.bar = new sample_service.Bar();
-    foo.name = "Example name";
-    foo.source = sourcePipe.handle0;
-    connection1.remote.frobinate(foo, true, anotherPipe.handle0);
-
-    mockSupport.pumpOnce(core.RESULT_OK);
-
-    expect(receivedFrobinate).toBeTruthy();
-    expect(receivedDidFrobinate).toBeTruthy();
-
-    connection0.close();
-    connection1.close();
-
-    expect(mockSupport.numberOfWaitingCallbacks()).toBe(0);
-
-    // sourcePipe.handle0 was closed automatically when sent over IPC.
-    expect(core.close(sourcePipe.handle0)).toBe(core.RESULT_INVALID_ARGUMENT);
-    // sourcePipe.handle1 hasn't been closed yet.
-    expect(core.close(sourcePipe.handle1)).toBe(core.RESULT_OK);
-
-    // anotherPipe.handle0 was closed automatically when sent over IPC.
-    expect(core.close(anotherPipe.handle0)).toBe(core.RESULT_INVALID_ARGUMENT);
-    // anotherPipe.handle1 hasn't been closed yet.
-    expect(core.close(anotherPipe.handle1)).toBe(core.RESULT_OK);
-
-    // The Connection object is responsible for closing these handles.
-    expect(core.close(pipe.handle0)).toBe(core.RESULT_INVALID_ARGUMENT);
-    expect(core.close(pipe.handle1)).toBe(core.RESULT_INVALID_ARGUMENT);
-  }
-
-  function testWriteToClosedPipe() {
-    var pipe = core.createMessagePipe();
-
-    var connection1 = new connection.Connection(
-        pipe.handle1, function() {}, sample_service.ServiceProxy);
-
-    // Close the other end of the pipe.
-    core.close(pipe.handle0);
-
-    // Not observed yet because we haven't pumped events yet.
-    expect(connection1.encounteredError()).toBeFalsy();
-
-    var foo = new sample_service.Foo();
-    foo.bar = new sample_service.Bar();
-    // TODO(darin): crbug.com/357043: pass null in place of |foo| here.
-    connection1.remote.frobinate(foo, true, core.kInvalidHandle);
-
-    // Write failures are not reported.
-    expect(connection1.encounteredError()).toBeFalsy();
-
-    // Pump events, and then we should start observing the closed pipe.
-    mockSupport.pumpOnce(core.RESULT_OK);
-
-    expect(connection1.encounteredError()).toBeTruthy();
-
-    connection1.close();
-  }
-
-  function testRequestResponse() {
-
-    // ProviderImpl ------------------------------------------------------------
-
-    function ProviderImpl(peer) {
-      this.peer = peer;
-    }
-
-    ProviderImpl.prototype =
-        Object.create(sample_interfaces.ProviderStub.prototype);
-
-    ProviderImpl.prototype.echoString = function(a, callback) {
-      callback(a);
-    };
-
-    ProviderImpl.prototype.echoStrings = function(a, b, callback) {
-      callback(a, b);
-    };
-
-    // ProviderClientImpl ------------------------------------------------------
-
-    function ProviderClientImpl(peer) {
-      this.peer = peer;
-    }
-
-    ProviderClientImpl.prototype =
-        Object.create(sample_interfaces.ProviderClientStub.prototype);
-
-    ProviderClientImpl.prototype.didFrobinate = function(result) {
-      receivedDidFrobinate = true;
-
-      expect(result).toBe(42);
-    };
-
-    var pipe = core.createMessagePipe();
-
-    var connection0 = new connection.Connection(
-        pipe.handle0, ProviderImpl, sample_interfaces.ProviderClientProxy);
-
-    var connection1 = new connection.Connection(
-        pipe.handle1, ProviderClientImpl, sample_interfaces.ProviderProxy);
-
-    var echoedString;
-
-    // echoString
-
-    connection1.remote.echoString("hello", function(a) {
-      echoedString = a;
-    });
-
-    mockSupport.pumpOnce(core.RESULT_OK);
-
-    expect(echoedString).toBe("hello");
-
-    // echoStrings
-
-    connection1.remote.echoStrings("hello", "world", function(a, b) {
-      echoedString = a + " " + b;
-    });
-
-    mockSupport.pumpOnce(core.RESULT_OK);
-
-    expect(echoedString).toBe("hello world");
-  }
-});
diff --git a/mojo/apps/js/bindings/connector_unittests.js b/mojo/apps/js/bindings/connector_unittests.js
new file mode 100644
index 0000000..d50f740
--- /dev/null
+++ b/mojo/apps/js/bindings/connector_unittests.js
@@ -0,0 +1,132 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Mock out the support module to avoid depending on the message loop.
+define("mojo/bindings/js/support", function() {
+  var waitingCallbacks = [];
+
+  function WaitCookie(id) {
+    this.id = id;
+  }
+
+  function asyncWait(handle, flags, callback) {
+    var id = waitingCallbacks.length;
+    waitingCallbacks.push(callback);
+    return new WaitCookie(id);
+  }
+
+  function cancelWait(cookie) {
+    waitingCallbacks[cookie.id] = null;
+  }
+
+  function numberOfWaitingCallbacks() {
+    var count = 0;
+    for (var i = 0; i < waitingCallbacks.length; ++i) {
+      if (waitingCallbacks[i])
+        ++count;
+    }
+    return count;
+  }
+
+  function pumpOnce(result) {
+    var callbacks = waitingCallbacks;
+    waitingCallbacks = [];
+    for (var i = 0; i < callbacks.length; ++i)
+      callbacks[i](result);
+  }
+
+  var exports = {};
+  exports.asyncWait = asyncWait;
+  exports.cancelWait = cancelWait;
+  exports.numberOfWaitingCallbacks = numberOfWaitingCallbacks;
+  exports.pumpOnce = pumpOnce;
+  return exports;
+});
+
+define([
+    "gin/test/expect",
+    "mojo/bindings/js/support",
+    "mojo/bindings/js/core",
+    "mojo/public/bindings/js/connector",
+    "mojo/public/bindings/tests/sample_service.mojom",
+], function(expect, mockSupport, core, connector, sample) {
+
+  var receivedFrobinate = false;
+  var receivedDidFrobinate = false;
+
+  // ServiceImpl --------------------------------------------------------------
+
+  function ServiceImpl(peer) {
+    this.peer = peer;
+  }
+
+  ServiceImpl.prototype = Object.create(sample.ServiceStub.prototype);
+
+  ServiceImpl.prototype.frobinate = function(foo, baz, port) {
+    receivedFrobinate = true;
+
+    expect(foo.name).toBe("Example name");
+    expect(baz).toBeTruthy();
+    expect(core.close(port)).toBe(core.RESULT_OK);
+
+    this.peer.didFrobinate(42);
+  };
+
+  // ServiceImpl --------------------------------------------------------------
+
+  function ServiceClientImpl(peer) {
+    this.peer = peer;
+  }
+
+  ServiceClientImpl.prototype =
+      Object.create(sample.ServiceClientStub.prototype);
+
+  ServiceClientImpl.prototype.didFrobinate = function(result) {
+    receivedDidFrobinate = true;
+
+    expect(result).toBe(42);
+  };
+
+  var pipe = core.createMessagePipe();
+  var anotherPipe = core.createMessagePipe();
+  var sourcePipe = core.createMessagePipe();
+
+  var connection0 = new connector.Connection(
+      pipe.handle0, ServiceImpl, sample.ServiceClientProxy);
+
+  var connection1 = new connector.Connection(
+      pipe.handle1, ServiceClientImpl, sample.ServiceProxy);
+
+  var foo = new sample.Foo();
+  foo.bar = new sample.Bar();
+  foo.name = "Example name";
+  foo.source = sourcePipe.handle0;
+  connection1.remote.frobinate(foo, true, anotherPipe.handle0);
+
+  mockSupport.pumpOnce(core.RESULT_OK);
+
+  expect(receivedFrobinate).toBeTruthy();
+  expect(receivedDidFrobinate).toBeTruthy();
+
+  connection0.close();
+  connection1.close();
+
+  expect(mockSupport.numberOfWaitingCallbacks()).toBe(0);
+
+  // sourcePipe.handle0 was closed automatically when sent over IPC.
+  expect(core.close(sourcePipe.handle0)).toBe(core.RESULT_INVALID_ARGUMENT);
+  // sourcePipe.handle1 hasn't been closed yet.
+  expect(core.close(sourcePipe.handle1)).toBe(core.RESULT_OK);
+
+  // anotherPipe.handle0 was closed automatically when sent over IPC.
+  expect(core.close(anotherPipe.handle0)).toBe(core.RESULT_INVALID_ARGUMENT);
+  // anotherPipe.handle1 hasn't been closed yet.
+  expect(core.close(anotherPipe.handle1)).toBe(core.RESULT_OK);
+
+  // The Connection object is responsible for closing these handles.
+  expect(core.close(pipe.handle0)).toBe(core.RESULT_INVALID_ARGUMENT);
+  expect(core.close(pipe.handle1)).toBe(core.RESULT_INVALID_ARGUMENT);
+
+  this.result = "PASS";
+});