mojo: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=sky@chromium.org, dcheng@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1731003003

Cr-Commit-Position: refs/heads/master@{#378262}

6 files changed, 10 insertions, 0 deletions

diff --git a/mojo/edk/system/dispatcher.cc b/mojo/edk/system/dispatcher.cc
index d475ef6..8a2e15e 100644
--- a/mojo/edk/system/dispatcher.cc
+++ b/mojo/edk/system/dispatcher.cc
@@ -17,6 +17,9 @@ namespace edk {
 
 Dispatcher::DispatcherInTransit::DispatcherInTransit() {}
 
+Dispatcher::DispatcherInTransit::DispatcherInTransit(
+    const DispatcherInTransit& other) = default;
+
 Dispatcher::DispatcherInTransit::~DispatcherInTransit() {}
 
 MojoResult Dispatcher::WriteMessage(const void* bytes,
diff --git a/mojo/edk/system/dispatcher.h b/mojo/edk/system/dispatcher.h
index 8bdff28..89876eb 100644
--- a/mojo/edk/system/dispatcher.h
+++ b/mojo/edk/system/dispatcher.h
@@ -41,6 +41,7 @@ class MOJO_SYSTEM_IMPL_EXPORT Dispatcher
  public:
   struct DispatcherInTransit {
     DispatcherInTransit();
+    DispatcherInTransit(const DispatcherInTransit& other);
     ~DispatcherInTransit();
 
     scoped_refptr<Dispatcher> dispatcher;
diff --git a/mojo/edk/system/handle_table.cc b/mojo/edk/system/handle_table.cc
index 7aeca64..e41817d 100644
--- a/mojo/edk/system/handle_table.cc
+++ b/mojo/edk/system/handle_table.cc
@@ -126,6 +126,8 @@ HandleTable::Entry::Entry() {}
 HandleTable::Entry::Entry(scoped_refptr<Dispatcher> dispatcher)
     : dispatcher(dispatcher) {}
 
+HandleTable::Entry::Entry(const Entry& other) = default;
+
 HandleTable::Entry::~Entry() {}
 
 }  // namespace edk
diff --git a/mojo/edk/system/handle_table.h b/mojo/edk/system/handle_table.h
index ecfb21e..882d540 100644
--- a/mojo/edk/system/handle_table.h
+++ b/mojo/edk/system/handle_table.h
@@ -53,6 +53,7 @@ class HandleTable {
   struct Entry {
    Entry();
    explicit Entry(scoped_refptr<Dispatcher> dispatcher);
+   Entry(const Entry& other);
    ~Entry();
 
    scoped_refptr<Dispatcher> dispatcher;
diff --git a/mojo/edk/system/wait_set_dispatcher.cc b/mojo/edk/system/wait_set_dispatcher.cc
index a083ce9..edca415 100644
--- a/mojo/edk/system/wait_set_dispatcher.cc
+++ b/mojo/edk/system/wait_set_dispatcher.cc
@@ -34,6 +34,8 @@ class WaitSetDispatcher::Waiter final : public Awakable {
 
 WaitSetDispatcher::WaitState::WaitState() {}
 
+WaitSetDispatcher::WaitState::WaitState(const WaitState& other) = default;
+
 WaitSetDispatcher::WaitState::~WaitState() {}
 
 WaitSetDispatcher::WaitSetDispatcher()
diff --git a/mojo/edk/system/wait_set_dispatcher.h b/mojo/edk/system/wait_set_dispatcher.h
index 11e82cd..5bf457f 100644
--- a/mojo/edk/system/wait_set_dispatcher.h
+++ b/mojo/edk/system/wait_set_dispatcher.h
@@ -52,6 +52,7 @@ class MOJO_SYSTEM_IMPL_EXPORT WaitSetDispatcher : public Dispatcher {
 
   struct WaitState {
     WaitState();
+    WaitState(const WaitState& other);
     ~WaitState();
 
     scoped_refptr<Dispatcher> dispatcher;