diff options
| author | tsergeant <tsergeant@chromium.org> | 2016-03-09 19:51:33 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-10 03:53:03 +0000 |
| commit | 896012863947ba511c55ce7c65aa1002cd3894eb (patch) | |
| tree | 81614102d853a7d1fc16e207083905ece2ae14e3 /mojo/edk | |
| parent | 4819f8b1cfab20b5598d5426ff48dbeae1b1955a (diff) | |
| download | chromium_src-896012863947ba511c55ce7c65aa1002cd3894eb.zip chromium_src-896012863947ba511c55ce7c65aa1002cd3894eb.tar.gz chromium_src-896012863947ba511c55ce7c65aa1002cd3894eb.tar.bz2 | |
Revert of Fix failing tests with ChannelMojo enabled. (patchset #3 id:300001 of https://codereview.chromium.org/1768903002/ )
Reason for revert:
This CL is causing failures in ipc_mojo_unittests.
See:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/52715
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/26588
Original issue's description:
> Fix failing tests with ChannelMojo enabled.
>
> This ChannelMojo to:
> - take a ScopedMessagePipeHandle instead of a string token so an
> in-process renderer can be passed the message pipe directly;
> - send brokered attachments as mojo handles; and
> - offer messages to AttachmentBroker.
>
> This also fixes and re-enables ipc_channel_mojo_unittest.cc.
>
> BUG=579813
>
> Committed: https://crrev.com/013cfed7ecf91b0700bec7147631d4fbedb6b64e
> Cr-Commit-Position: refs/heads/master@{#380294}
TBR=rockot@chromium.org,tsepez@chromium.org,ben@chromium.org,sammc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=579813
Review URL: https://codereview.chromium.org/1784773002
Cr-Commit-Position: refs/heads/master@{#380325}
Diffstat (limited to 'mojo/edk')
| -rw-r--r-- | mojo/edk/embedder/embedder.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/mojo/edk/embedder/embedder.h b/mojo/edk/embedder/embedder.h index 99191a9..95b3b21 100644 --- a/mojo/edk/embedder/embedder.h +++ b/mojo/edk/embedder/embedder.h @@ -75,8 +75,8 @@ CreatePlatformHandleWrapper(ScopedPlatformHandle platform_handle, MojoHandle* platform_handle_wrapper_handle); // Retrieves the |PlatformHandle| that was wrapped into a |MojoHandle| (using -// |CreatePlatformHandleWrapper()| above). Note that the |MojoHandle| is closed -// on success. +// |CreatePlatformHandleWrapper()| above). Note that the |MojoHandle| must still +// be closed separately. MOJO_SYSTEM_IMPL_EXPORT MojoResult PassWrappedPlatformHandle(MojoHandle platform_handle_wrapper_handle, ScopedPlatformHandle* platform_handle); |