diff options
| author | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-26 23:14:10 +0000 |
|---|---|---|
| committer | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-26 23:14:10 +0000 |
| commit | d756d00b365461c6ab155df195dda8db338eb279 (patch) | |
| tree | 88dcf0a5ba7da1e7b3ea377a1509e077bae5a3fc /mojo/embedder | |
| parent | 171e3adc2055879487a9e4f3f902371215f2b3bc (diff) | |
| download | chromium_src-d756d00b365461c6ab155df195dda8db338eb279.zip chromium_src-d756d00b365461c6ab155df195dda8db338eb279.tar.gz chromium_src-d756d00b365461c6ab155df195dda8db338eb279.tar.bz2 | |
Mojo: Check return value of fwrite() in PlatformChannelPairPosixTest.
Apparently, on some platforms (compilers/libraries), our build will fail
if we ignore the return value of fwrite().
R=sky@chromium.org
Review URL: https://codereview.chromium.org/351303004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280157 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'mojo/embedder')
| -rw-r--r-- | mojo/embedder/platform_channel_pair_posix_unittest.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/mojo/embedder/platform_channel_pair_posix_unittest.cc b/mojo/embedder/platform_channel_pair_posix_unittest.cc index 02f1900..672f252 100644 --- a/mojo/embedder/platform_channel_pair_posix_unittest.cc +++ b/mojo/embedder/platform_channel_pair_posix_unittest.cc @@ -147,7 +147,7 @@ TEST_F(PlatformChannelPairPosixTest, SendReceiveFDs) { base::ScopedFILE fp( base::CreateAndOpenTemporaryFileInDir(temp_dir.path(), &unused)); ASSERT_TRUE(fp); - fwrite(std::string(j, '0' + i).data(), 1, j, fp.get()); + ASSERT_EQ(j, fwrite(std::string(j, '0' + i).data(), 1, j, fp.get())); platform_handles.push_back( test::PlatformHandleFromFILE(fp.Pass()).release()); ASSERT_TRUE(platform_handles.back().is_valid()); @@ -203,7 +203,8 @@ TEST_F(PlatformChannelPairPosixTest, AppendReceivedFDs) { base::ScopedFILE fp(base::CreateAndOpenTemporaryFileInDir(temp_dir.path(), &unused)); ASSERT_TRUE(fp); - fwrite(file_contents.data(), 1, file_contents.size(), fp.get()); + ASSERT_EQ(file_contents.size(), + fwrite(file_contents.data(), 1, file_contents.size(), fp.get())); PlatformHandleVector platform_handles; platform_handles.push_back( test::PlatformHandleFromFILE(fp.Pass()).release()); |