diff options
| author | zea <zea@chromium.org> | 2014-10-06 19:37:47 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-10-07 02:37:59 +0000 |
| commit | c79e745f391651a7e79b2499c27789fdfbd49a5d (patch) | |
| tree | 1e44f6866dfae6edd8e075091f5af8673d48a2cb /mojo/environment | |
| parent | 239c9f3ca43aa341b8362c7c622c78e2347d2d60 (diff) | |
| download | chromium_src-c79e745f391651a7e79b2499c27789fdfbd49a5d.zip chromium_src-c79e745f391651a7e79b2499c27789fdfbd49a5d.tar.gz chromium_src-c79e745f391651a7e79b2499c27789fdfbd49a5d.tar.bz2 | |
[Sync] Refactor Sync active status
sync_initialized was being misused in many places to mean "sync is up and
running". In a sense this is what ShouldPushChanges was for, but that name
was somewhat misleading, and also the implementation didn't take into account
that the datatype manager can be configuring and yet there may still be data
and sync may be active.
This change therefore renames sync_initialized to backend_initialized (which is
what is was always checking), and changes ShouldPushChanges to SyncActive,
which verifies that sync is up and running properly.
Because SyncActive is no longer verifying that the datatype manager is not in the
middle of a configuration, GetActiveTypes now checks that a configuration is
not currently in flight. This also addresses the issues that GetActiveTypes
previously might give stale data if types were in the middle of being disabled.
BUG=418141
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/612573006
Cr-Commit-Position: refs/heads/master@{#298336}
Diffstat (limited to 'mojo/environment')
0 files changed, 0 insertions, 0 deletions