diff options
| author | ben <ben@chromium.org> | 2015-11-03 14:06:52 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-11-03 22:07:31 +0000 |
| commit | d621742cb094ec9caff33d026eb72e18bded6e8e (patch) | |
| tree | a51e06ce2a4be2fe11e6bf6fcbe37cb62cf9c775 /mojo/platform_handle | |
| parent | c3a9a1736ca602c624d7b2aaff555bd3ebf9f64b (diff) | |
| download | chromium_src-d621742cb094ec9caff33d026eb72e18bded6e8e.zip chromium_src-d621742cb094ec9caff33d026eb72e18bded6e8e.tar.gz chromium_src-d621742cb094ec9caff33d026eb72e18bded6e8e.tar.bz2 | |
Window Type Launcher as a process.
When run in child process mode, mojo_runner sets thunks in .mojo DLLs that allow various mojo system calls to work. These thunks are only needed for .DLLs loaded in this manner. When the mojo runner launches a standalone executable, the executable should statically link the real implementations of the system calls, not the thunks.
The problem was that there were a couple of client libs that implicitly depended on the thunks. The fix was to make this not be the case and instead:
- standalone executable targets statically link the real implementations (e.g. //mojo/gles2 and //mojo/runner:platform_handle)
- .mojo targets statically link the thunk targets, these dependencies are added automatically by the mojo_application gn target.
R=jam@chromium.org
http://crbug.com/548694
Review URL: https://codereview.chromium.org/1409393008
Cr-Commit-Position: refs/heads/master@{#357646}
Diffstat (limited to 'mojo/platform_handle')
| -rw-r--r-- | mojo/platform_handle/BUILD.gn | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/mojo/platform_handle/BUILD.gn b/mojo/platform_handle/BUILD.gn index e6a1dc0..f224dd9 100644 --- a/mojo/platform_handle/BUILD.gn +++ b/mojo/platform_handle/BUILD.gn @@ -25,9 +25,10 @@ source_set("platform_handle") { source_set("defs") { visibility = [ ":platform_handle", + "//components/font_service/public/cpp", "//components/mus/gles2", "//mojo/gles2", - "//mojo/runner:native_application_support", + "//mojo/runner:platform_handle", ] sources = [ |