diff options
author | binjin <binjin@chromium.org> | 2014-10-30 03:45:26 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-30 10:45:52 +0000 |
commit | 6b7fc0b1e9ce197220ce0453843461c8cc950ab0 (patch) | |
tree | f7cfc3d6312f21ed86e10f9d82a9434d14defbd7 /mojo/public/cpp/application/application_test_base.h | |
parent | eb1504475d05411b479912b2c896862221f21d51 (diff) | |
download | chromium_src-6b7fc0b1e9ce197220ce0453843461c8cc950ab0.zip chromium_src-6b7fc0b1e9ce197220ce0453843461c8cc950ab0.tar.gz chromium_src-6b7fc0b1e9ce197220ce0453843461c8cc950ab0.tar.bz2 |
Revert of Update mojo sdk to rev e083961bf11fd0c94d40be8853761da529b6d444 (patchset #6 id:120001 of https://codereview.chromium.org/683583002/)
Reason for revert:
Suspected to cause android bot failures:
New warnings.
Please fix, or perhaps add to /b/build/slave/Android_Builder__dbg_/build/src/build/android/findbugs_filter/findbugs_known_bugs.txt
--------------------------------------------------------------------------------
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.imported.ImportedInterface_Internal$ImportedInterfaceDoSomethingParams.equals(Object) At ImportedInterface_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.math.Calculator_Internal$CalculatorClearParams.equals(Object) At Calculator_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.mojo.IntegrationTestInterface2_Internal$IntegrationTestInterface2Method0Params.equals(Object) At IntegrationTestInterface2_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.CheckMethodWithEmptyResponse_Internal$CheckMethodWithEmptyResponseWithParameterAndEmptyResponseResponseParams.equals(Object) At CheckMethodWithEmptyResponse_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.CheckMethodWithEmptyResponse_Internal$CheckMethodWithEmptyResponseWithouParameterAndEmptyResponseParams.equals(Object) At CheckMethodWithEmptyResponse_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.CheckMethodWithEmptyResponse_Internal$CheckMethodWithEmptyResponseWithouParameterAndEmptyResponseResponseParams.equals(Object) At CheckMethodWithEmptyResponse_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.EmptyStruct.equals(Object) At EmptyStruct.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.sample.NamedObject_Internal$NamedObjectGetNameParams.equals(Object) At NamedObject_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.test_structs.EmptyStruct.equals(Object) At EmptyStruct.java
--------------------------------------------------------------------------------
*** 9 FindBugs warnings! ***
*** 9: new ***
Original issue's description:
> Update mojo sdk to rev e083961bf11fd0c94d40be8853761da529b6d444
>
> TBR=jam@chromium.org
>
> Committed: https://crrev.com/37273cab357d03ad9d2bcfa4ae467567ce93e2c4
> Cr-Commit-Position: refs/heads/master@{#302038}
TBR=jamesr@chromium.org,aa@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/694463002
Cr-Commit-Position: refs/heads/master@{#302066}
Diffstat (limited to 'mojo/public/cpp/application/application_test_base.h')
-rw-r--r-- | mojo/public/cpp/application/application_test_base.h | 50 |
1 files changed, 0 insertions, 50 deletions
diff --git a/mojo/public/cpp/application/application_test_base.h b/mojo/public/cpp/application/application_test_base.h deleted file mode 100644 index 7fe38d2..0000000 --- a/mojo/public/cpp/application/application_test_base.h +++ /dev/null @@ -1,50 +0,0 @@ -// Copyright 2014 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef MOJO_PUBLIC_CPP_APPLICATION_APPLICATION_TEST_BASE_H_ -#define MOJO_PUBLIC_CPP_APPLICATION_APPLICATION_TEST_BASE_H_ - -#include "mojo/public/cpp/bindings/array.h" -#include "mojo/public/cpp/bindings/string.h" -#include "mojo/public/cpp/system/macros.h" -#include "testing/gtest/include/gtest/gtest.h" - -namespace mojo { - -class ApplicationDelegate; -class ApplicationImpl; - -namespace test { - -// A GTEST base class for application testing executed in mojo_shell. -class ApplicationTestBase : public testing::Test { - public: - explicit ApplicationTestBase(Array<String> args); - ~ApplicationTestBase() override; - - protected: - ApplicationImpl* application_impl() { return application_impl_; } - - // Get the ApplicationDelegate for the application to be tested. - virtual ApplicationDelegate* GetApplicationDelegate() = 0; - - // testing::Test: - void SetUp() override; - void TearDown() override; - - private: - // The command line arguments supplied to each test application instance. - Array<String> args_; - - // The application implementation instance, reconstructed for each test. - ApplicationImpl* application_impl_; - - MOJO_DISALLOW_COPY_AND_ASSIGN(ApplicationTestBase); -}; - -} // namespace test - -} // namespace mojo - -#endif // MOJO_PUBLIC_CPP_APPLICATION_APPLICATION_TEST_BASE_H_ |