diff options
| author | rockot <rockot@chromium.org> | 2015-12-16 13:46:42 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-12-16 21:47:25 +0000 |
| commit | 206fbc4fe87bb5cd0b599c38cf5aac278329d575 (patch) | |
| tree | 0234d76da111635b16ab2a74d31a858680fc6259 /mojo/public/tools/bindings/generators | |
| parent | 98796aa4836f4256dc6b9ce86a83b7ddb1fc59f9 (diff) | |
| download | chromium_src-206fbc4fe87bb5cd0b599c38cf5aac278329d575.zip chromium_src-206fbc4fe87bb5cd0b599c38cf5aac278329d575.tar.gz chromium_src-206fbc4fe87bb5cd0b599c38cf5aac278329d575.tar.bz2 | |
[mojo] Suppress findbugs errors on generated bindings
The Java bindings haven't changed for quite some time, so
either due to changes in findbugs or to what targets we run
findbugs on, these errors have started popping up and blocking
try jobs.
This suppresses them for now until more investigation can
be done.
BUG=570386
TBR=yzshen@chromium.org
Review URL: https://codereview.chromium.org/1529093004
Cr-Commit-Position: refs/heads/master@{#365627}
Diffstat (limited to 'mojo/public/tools/bindings/generators')
| -rw-r--r-- | mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl | 6 | ||||
| -rw-r--r-- | mojo/public/tools/bindings/generators/java_templates/header.java.tmpl | 2 |
2 files changed, 8 insertions, 0 deletions
diff --git a/mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl b/mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl index cd4ee86..34170a3 100644 --- a/mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl +++ b/mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl @@ -261,11 +261,17 @@ public final class {{union|name}} extends org.chromium.mojo.bindings.Union { } {% for field in union.fields %} + // TODO(rockot): Fix the findbugs error and remove this suppression. + // See http://crbug.com/570386. + @SuppressFBWarnings("EI_EXPOSE_REP2") public void set{{field|ucc}}({{field.kind|java_type}} {{field|name}}) { mTag_ = {{field.ordinal}}; m{{field|ucc}} = {{field|name}}; } + // TODO(rockot): Fix the findbugs error and remove this suppression. + // See http://crbug.com/570386. + @SuppressFBWarnings("EI_EXPOSE_REP") public {{field.kind|java_type}} get{{field|ucc}}() { assert mTag_ == {{field.ordinal}}; return m{{field|ucc}}; diff --git a/mojo/public/tools/bindings/generators/java_templates/header.java.tmpl b/mojo/public/tools/bindings/generators/java_templates/header.java.tmpl index ec6a88b..6a23c66 100644 --- a/mojo/public/tools/bindings/generators/java_templates/header.java.tmpl +++ b/mojo/public/tools/bindings/generators/java_templates/header.java.tmpl @@ -9,3 +9,5 @@ // package {{package}}; + +import org.chromium.base.annotations.SuppressFBWarnings; |