diff options
| author | fsamuel <fsamuel@chromium.org> | 2015-07-07 07:51:39 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-07 14:52:53 +0000 |
| commit | d8eddd344341fee0aca4d5846a0f5d5ef2c2a037 (patch) | |
| tree | 03bbb8fc379be4f9d0d1d5e120e24dc6ba61a217 /mojo/runner/switches.cc | |
| parent | 128c8573daa2a188b05db7121382d44dc73540e0 (diff) | |
| download | chromium_src-d8eddd344341fee0aca4d5846a0f5d5ef2c2a037.zip chromium_src-d8eddd344341fee0aca4d5846a0f5d5ef2c2a037.tar.gz chromium_src-d8eddd344341fee0aca4d5846a0f5d5ef2c2a037.tar.bz2 | |
Revert of mandoline filesystem: Save cookie data to the mojo:filesystem. (patchset #16 id:300001 of https://codereview.chromium.org/1179413010/)
Reason for revert:
I'm seeing the following crash when closing the Mandoline window on Linux:
[0707/104753:FATAL:sqlite_persistent_cookie_store.cc(1135)] Check failed: false. Could not add a cookie to the DB.
#0 0x00000046aef1 __interceptor_backtrace
#1 0x7fec4b87954e base::debug::StackTrace::StackTrace()
#2 0x7fec4b479a1d logging::LogMessage::~LogMessage()
#3 0x7fec53f03c23 net::SQLitePersistentCookieStore::Backend::Commit()
#4 0x7fec53f04f38 net::SQLitePersistentCookieStore::Backend::InternalBackgroundClose()
#5 0x7fec53f1902b base::internal::RunnableAdapter<>::Run()
Reverting this patch resolves the issue.
Original issue's description:
> mandoline filesystem: Save cookie data to the mojo:filesystem.
>
> This makes the network service use the sql vfs to proxy writing the
> cookies to the filesystem service. This means mojo:network_service does
> not directly write its data to the OS filesystem, which will allow us to
> sandbox it.
>
> BUG=493311
>
> Committed: https://crrev.com/bbb9e2f6486cccadde4dc2fa077af8f694105eaa
> Cr-Commit-Position: refs/heads/master@{#337491}
TBR=jam@chromium.org,msw@chromium.org,sky@chromium.org,shess@chromium.org,erg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=493311
Review URL: https://codereview.chromium.org/1225673006
Cr-Commit-Position: refs/heads/master@{#337602}
Diffstat (limited to 'mojo/runner/switches.cc')
| -rw-r--r-- | mojo/runner/switches.cc | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/mojo/runner/switches.cc b/mojo/runner/switches.cc index f4290f6..1ed957e 100644 --- a/mojo/runner/switches.cc +++ b/mojo/runner/switches.cc @@ -50,12 +50,4 @@ const char kTraceStartup[] = "trace-startup"; // the first maps 'a' to 'b' and the second 'c' to 'd'. const char kURLMappings[] = "url-mappings"; -// When this is set, we create a temporary user data dir for the process, and -// add a flag so kUserDataDir points to it. -const char kUseTemporaryUserDataDir[] = "use-temporary-user-data-dir"; - -// Specifies the user data directory. This is the one directory which stores -// all persistent data. -const char kUserDataDir[] = "user-data-dir"; - } // namespace switches |